AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

cppgc: Cleanup regression test

Browse Source 
Bug: v8:10989
Change-Id: I65a3d8bfb34322c088df9439b9c756cec3eeff81
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2453731
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70362}
This commit is contained in:
Omer Katz 2020-10-06 23:08:27 +02:00 committed by Commit Bot
parent ac35661ca1
commit 89af4ca794
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unittests/heap/cppgc/marking-verifier-unittest.cc
View File

@ -121,9 +121,9 @@ struct Holder : public GarbageCollected<Holder<T>> {
} // namespace
TEST_F(MarkingVerifierTest, DoesntDieOnInConstructionObjectWithWriteBarrier) {
// Regression test: https://bugs.chromium.org/p/v8/issues/detail?id=10989.
// Regression test: https://crbug.com/v8/10989.
// GCedWithCallbackAndChild is marked by write barrier and then discarded by
// FlushNotFullyConstructedObjects because it is already marked. This test
// FlushNotFullyConstructedObjects because it is already marked.
Persistent<Holder<GCedWithCallbackAndChild>> persistent =
MakeGarbageCollected<Holder<GCedWithCallbackAndChild>>(
GetAllocationHandle());