AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] use OS independent number to string conversion

Browse Source 
V8 internally uses conversions.h to convert number to string, we can use these methods too instead of slow std::stringstream with std::locale.

BUG=chromium:661497,v8:5551
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2534013002
Cr-Commit-Position: refs/heads/master@{#41334}
This commit is contained in:
kozyatinskiy 2016-11-28 16:33:59 -08:00 committed by Commit bot
parent bc1a3820c2
commit 89d050c066
2 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/inspector/DEPS
View File

@ -4,6 +4,7 @@ include_rules = [
"+src/base/macros.h",
"+src/base/logging.h",
"+src/base/platform/platform.h",
"+src/conversions.h",
"+src/inspector",
"+src/tracing",
"-include/v8-debug.h",

26
src/inspector/string-16.cc
View File

@ -8,13 +8,11 @@
#include <cctype>
#include <cstdlib>
#include <cstring>
#include <iomanip>
#include <limits>
#include <locale>
#include <sstream>
#include <string>
#include "src/base/platform/platform.h"
#include "src/conversions.h"
namespace v8_inspector {
@ -366,10 +364,9 @@ static inline void putUTF8Triple(char*& buffer, UChar ch) {
// static
String16 String16::fromInteger(int number) {
const size_t kBufferSize = 50;
char buffer[kBufferSize];
v8::base::OS::SNPrintF(buffer, kBufferSize, "%d", number);
return String16(buffer);
char arr[50];
v8::internal::Vector<char> buffer(arr, arraysize(arr));
return String16(IntToCString(number, buffer));
}
// static
@ -386,19 +383,16 @@ String16 String16::fromInteger(size_t number) {
// static
String16 String16::fromDouble(double number) {
std::ostringstream s;
s.imbue(std::locale("C"));
s << std::fixed << std::setprecision(std::numeric_limits<double>::digits10)
<< number;
return String16(s.str().c_str());
char arr[50];
v8::internal::Vector<char> buffer(arr, arraysize(arr));
return String16(DoubleToCString(number, buffer));
}
// static
String16 String16::fromDouble(double number, int precision) {
std::ostringstream s;
s.imbue(std::locale("C"));
s << std::fixed << std::setprecision(precision) << number;
return String16(s.str().c_str());
std::unique_ptr<char[]> str(
v8::internal::DoubleToPrecisionCString(number, precision));
return String16(str.get());
}
int String16::toInteger(bool* ok) const {