AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Rename ThreadManager::IterateThreads to ThreadManager::IterateArchivedThreads

Browse Source 
The IterateThreads method only iterates archived threads. If all
threads are to be iterated an additional iteration of the current active
stack is also needed.


Review URL: http://codereview.chromium.org/2655002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
ricow@chromium.org 2010-06-04 11:57:01 +00:00
parent 12f6306420
commit 8a4d49b65a
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/heap.cc
View File

@ -560,7 +560,7 @@ class ClearThreadJSFunctionResultCachesVisitor: public ThreadVisitor {
void Heap::ClearJSFunctionResultCaches() { void Heap::ClearJSFunctionResultCaches() {
if (Bootstrapper::IsActive()) return; if (Bootstrapper::IsActive()) return;
ClearThreadJSFunctionResultCachesVisitor visitor; ClearThreadJSFunctionResultCachesVisitor visitor;
ThreadManager::IterateThreads(&visitor); ThreadManager::IterateArchivedThreads(&visitor);
} }

4
src/liveedit.cc
View File

@ -794,7 +794,7 @@ class FrameUncookingThreadVisitor : public ThreadVisitor {
static void IterateAllThreads(ThreadVisitor* visitor) { static void IterateAllThreads(ThreadVisitor* visitor) {
Top::IterateThread(visitor); Top::IterateThread(visitor);
ThreadManager::IterateThreads(visitor); ThreadManager::IterateArchivedThreads(visitor);
} }
// Finds all references to original and replaces them with substitution. // Finds all references to original and replaces them with substitution.
@ -1386,7 +1386,7 @@ Handle<JSArray> LiveEdit::CheckAndDropActivations(
// First check inactive threads. Fail if some functions are blocked there. // First check inactive threads. Fail if some functions are blocked there.
InactiveThreadActivationsChecker inactive_threads_checker(shared_info_array, InactiveThreadActivationsChecker inactive_threads_checker(shared_info_array,
result); result);
ThreadManager::IterateThreads(&inactive_threads_checker); ThreadManager::IterateArchivedThreads(&inactive_threads_checker);
if (inactive_threads_checker.HasBlockedFunctions()) { if (inactive_threads_checker.HasBlockedFunctions()) {
return result; return result;
} }

2
src/v8threads.cc
View File

@ -331,7 +331,7 @@ void ThreadManager::Iterate(ObjectVisitor* v) {
} }
void ThreadManager::IterateThreads(ThreadVisitor* v) { void ThreadManager::IterateArchivedThreads(ThreadVisitor* v) {
for (ThreadState* state = ThreadState::FirstInUse(); for (ThreadState* state = ThreadState::FirstInUse();
state != NULL; state != NULL;
state = state->Next()) { state = state->Next()) {

2
src/v8threads.h
View File

@ -104,7 +104,7 @@ class ThreadManager : public AllStatic {
static bool IsArchived(); static bool IsArchived();
static void Iterate(ObjectVisitor* v); static void Iterate(ObjectVisitor* v);
static void IterateThreads(ThreadVisitor* v); static void IterateArchivedThreads(ThreadVisitor* v);
static void MarkCompactPrologue(bool is_compacting); static void MarkCompactPrologue(bool is_compacting);
static void MarkCompactEpilogue(bool is_compacting); static void MarkCompactEpilogue(bool is_compacting);
static bool IsLockedByCurrentThread() { return mutex_owner_.IsSelf(); } static bool IsLockedByCurrentThread() { return mutex_owner_.IsSelf(); }