AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test262] Test262 Roll

Browse Source 
Fixes broken background compile error reporting.

Fixes broken tests in DateTimeFormat and NumberFormat: PluralRules
constructor requires 'new'.

Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I65216a3172595397f5de638c9d5d9d021d3257ce
Reviewed-on: https://chromium-review.googlesource.com/931935
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51488}
This commit is contained in:
Sathya Gunasekaran 2018-02-22 12:25:56 -08:00 committed by Commit Bot
parent 56b4c41b6a
commit 8a78db6d4a
7 changed files with 76 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
DEPS
View File

@ -55,7 +55,7 @@ deps = {
'v8/test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'v8/test/test262/data':
Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '8311965251953d4745aeb68c98fb71fab2eac1d0',
Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'b59d956b3c268abd0875aeb87d6688f4c7aafc9b',
'v8/test/test262/harness':
Var('chromium_url') + '/external/github.com/test262-utils/test262-harness-py.git' + '@' + '0f2acdd882c84cff43b9d60df7574a1901e2cdcd',
'v8/tools/clang':

3
src/compiler.cc
View File

@ -1779,7 +1779,8 @@ Compiler::GetSharedFunctionInfoForStreamedScript(
&streaming_data->inner_function_jobs);
} else {
// Compilation failed on background thread - throw an exception.
if (!isolate->has_pending_exception()) isolate->StackOverflow();
FailWithPendingException(isolate, parse_info,
Compiler::ClearExceptionFlag::KEEP_EXCEPTION);
}
} else {
// Compilation on main thread.

1
test/cctest/test-parsing.cc
View File

@ -10346,6 +10346,7 @@ TEST(PrivateNamesSyntaxError) {
// TODO(gsathya): The preparser does not track unresolved
// variables in top level function which fails this test.
// https://bugs.chromium.org/p/v8/issues/detail?id=7468
const char* parser_data[] = {
"function t() {"
" return this.#foo;"

7
test/test262/local-tests/test/intl402/DateTimeFormat/12.1.1_1.js
View File

@ -31,12 +31,5 @@ testWithIntlConstructors(function (Constructor) {
$ERROR("DateTimeFormat object created with \"new\" was not ignored as this-value.");
}
// variant 2: use constructor as a function
obj = Constructor();
newObj = Intl.DateTimeFormat.call(obj);
if (obj === newObj) {
$ERROR("DateTimeFormat object created with constructor as function was not ignored as this-value.");
}
return true;
});

7
test/test262/local-tests/test/intl402/NumberFormat/11.1.1_1.js
View File

@ -31,12 +31,5 @@ testWithIntlConstructors(function (Constructor) {
$ERROR("NumberFormat object created with \"new\" was not ignored as this-value.");
}
// variant 2: use constructor as a function
obj = Constructor();
newObj = Intl.NumberFormat.call(obj);
if (obj === newObj) {
$ERROR("NumberFormat object created with constructor as function was not ignored as this-value.");
}
return true;
});

91
test/test262/test262.status
View File

@ -87,16 +87,21 @@
# https://bugs.chromium.org/p/v8/issues/detail?id=4895
'built-ins/TypedArrays/internals/DefineOwnProperty/detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/DefineOwnProperty/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/DefineOwnProperty/tonumber-value-detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/Get/detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/Get/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/Get/infinity-detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/GetOwnProperty/detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/GetOwnProperty/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/GetOwnProperty/enumerate-detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/HasProperty/detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/HasProperty/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/HasProperty/infinity-with-detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/Set/detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/Set/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/Set/tonumber-value-detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/DefineOwnProperty/tonumber-value-detached-buffer': [FAIL],
'built-ins/TypedArrays/typedarray-arg-detached-when-species-retrieved-different-type': [FAIL],
'built-ins/TypedArrays/typedarray-arg-detached-when-species-retrieved-same-type': [FAIL],
# Some TypedArray methods throw due to the same bug, from Get
'built-ins/TypedArray/prototype/every/callbackfn-detachbuffer': [FAIL],
'built-ins/TypedArray/prototype/find/predicate-may-detach-buffer': [FAIL],
@ -263,7 +268,15 @@
# https://bugs.chromium.org/p/v8/issues/detail?id=4698
'language/expressions/call/tco-call-args': [SKIP],
'language/expressions/call/tco-cross-realm-class-construct': [SKIP],
'language/expressions/call/tco-cross-realm-class-derived-construct': [SKIP],
'language/expressions/call/tco-cross-realm-fun-call': [SKIP],
'language/expressions/call/tco-cross-realm-fun-construct': [SKIP],
'language/expressions/call/tco-member-args': [SKIP],
'language/expressions/call/tco-non-eval-function': [SKIP],
'language/expressions/call/tco-non-eval-function-dynamic': [SKIP],
'language/expressions/call/tco-non-eval-global': [SKIP],
'language/expressions/call/tco-non-eval-with': [SKIP],
'language/expressions/comma/tco-final': [SKIP],
'language/expressions/conditional/tco-cond': [SKIP],
'language/expressions/conditional/tco-pos': [SKIP],
@ -291,14 +304,6 @@
'language/statements/try/tco-finally': [SKIP],
'language/statements/while/tco-body': [SKIP],
# https://github.com/tc39/test262/pull/972
'language/expressions/tagged-template/cache-identical-source-new-function': [FAIL],
'language/expressions/tagged-template/cache-identical-source': [FAIL],
'language/expressions/tagged-template/cache-differing-expressions-eval': [FAIL],
'language/expressions/tagged-template/cache-identical-source-eval': [FAIL],
'language/expressions/tagged-template/cache-differing-expressions-new-function': [FAIL],
'language/expressions/tagged-template/cache-differing-expressions': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=5064
'language/expressions/arrow-function/dflt-params-duplicates': [FAIL],
'language/expressions/async-arrow-function/dflt-params-duplicates': [FAIL],
@ -414,10 +419,6 @@
'built-ins/TypedArrays/buffer-arg-use-default-proto-if-custom-proto-is-not-object-sab': ['--harmony-sharedarraybuffer'],
'built-ins/TypedArrays/internals/Get/indexed-value-sab': ['--harmony-sharedarraybuffer'],
# https://bugs.chromium.org/p/v8/issues/detail?id=6045
'intl402/NumberFormat/prototype/format/11.3.2_TRF': [FAIL],
'intl402/NumberFormat/prototype/format/11.3.2_TRP': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=6049
'built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller': [FAIL_SLOPPY],
'built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments': [FAIL_SLOPPY],
@ -446,6 +447,59 @@
'language/statements/class/fields-indirect-eval-err-contains-arguments': [FAIL],
'language/expressions/class/fields-indirect-eval-err-contains-arguments': [FAIL],
# https://github.com/tc39/test262/pull/1452
'built-ins/Object/setPrototypeOf/bigint': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7468
'language/statements/class/privatename-not-valid-earlyerr-script-8': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=5690
'language/expressions/call/eval-spread': [FAIL],
'language/expressions/call/eval-spread-empty-leading': [FAIL],
'language/expressions/call/eval-spread-empty-trailing': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7470
'language/module-code/namespace/internals/enumerate-binding-uninit': [FAIL],
'language/module-code/namespace/internals/object-keys-binding-uninit': [FAIL],
'language/module-code/namespace/internals/object-propertyIsEnumerable-binding-uninit': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7471
'intl402/DateTimeFormat/prototype/format/time-clip-near-time-boundaries': [FAIL],
'intl402/DateTimeFormat/prototype/format/time-clip-to-integer': [FAIL],
'intl402/DateTimeFormat/prototype/formatToParts/time-clip-near-time-boundaries': [FAIL],
'intl402/DateTimeFormat/prototype/formatToParts/time-clip-to-integer': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7472
'intl402/NumberFormat/currency-digits': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7473
'intl402/language-tags-canonicalized': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7474
'intl402/NumberFormat/prototype/format/format-fraction-digits': [FAIL],
'intl402/NumberFormat/prototype/format/format-significant-digits': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7475
'built-ins/Date/UTC/non-integer-values': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7480
'intl402/Collator/unicode-ext-seq-in-private-tag': [FAIL],
'intl402/Collator/unicode-ext-seq-with-attribute': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7481
'intl402/NumberFormat/ignore-invalid-unicode-ext-values': [FAIL],
'intl402/DateTimeFormat/ignore-invalid-unicode-ext-values': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7482
'intl402/DateTimeFormat/prototype/resolvedOptions/resolved-locale-with-hc-unicode': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7483
'annexB/built-ins/Function/createdynfn-html-close-comment-params': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=5012
'intl402/Intl/getCanonicalLocales/canonicalized-tags': [FAIL],
'intl402/Intl/getCanonicalLocales/preferred-grandfathered': [FAIL],
'intl402/Intl/getCanonicalLocales/preferred-variant': [FAIL],
######################## NEEDS INVESTIGATION ###########################
@ -453,17 +507,7 @@
# to be either marked as bugs with issues filed for them or as deliberate
# incompatibilities if the test cases turn out to be broken or ambiguous.
# Some of these are related to v8:4361 in being visible side effects from Intl.
'intl402/6.2.3_a': [FAIL],
'intl402/Collator/10.1.2_a': [PASS, FAIL],
'intl402/Collator/10.2.3_b': [PASS, FAIL],
'intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle': [FAIL],
'intl402/DateTimeFormat/12.1.2': [PASS, FAIL],
'intl402/DateTimeFormat/12.2.3_b': [FAIL],
'intl402/Number/prototype/toLocaleString/13.2.1_5': [PASS, FAIL],
'intl402/NumberFormat/11.1.1_20_c': [FAIL],
'intl402/NumberFormat/11.1.2': [PASS, FAIL],
'intl402/NumberFormat/11.2.3_b': [FAIL],
'intl402/String/prototype/localeCompare/13.1.1_7': [PASS, FAIL],
##################### DELIBERATE INCOMPATIBILITIES #####################
@ -548,7 +592,6 @@
'built-ins/decodeURIComponent/S15.1.3.2_A1.12_T1': [SKIP],
'built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1': [SKIP],
'built-ins/RegExp/S15.10.2.12_A3_T1': [SKIP],
'intl402/9.2.6_4_b': [SKIP],
'language/literals/regexp/S7.8.5_A1.1_T2': [SKIP],
'language/literals/regexp/S7.8.5_A1.4_T2': [SKIP],
'language/literals/regexp/S7.8.5_A2.1_T2': [SKIP],

7
test/test262/testcfg.py
View File

@ -47,11 +47,14 @@ FEATURE_FLAGS = {
'regexp-named-groups': '--harmony-regexp-named-captures',
'regexp-unicode-property-escapes': '--harmony-regexp-property',
'Promise.prototype.finally': '--harmony-promise-finally',
'class-fields-public': '--harmony-class-fields',
'class-fields-public': '--harmony-public-fields',
'optional-catch-binding': '--harmony-optional-catch-binding',
'class-fields-private': '--harmony-private-fields',
}
SKIPPED_FEATURES = set(['class-fields-private'])
SKIPPED_FEATURES = set(['Array.prototype.flatten',
'Array.prototype.flatMap',
'numeric-separator-literal'])
DATA = os.path.join(os.path.dirname(os.path.abspath(__file__)), "data")
ARCHIVE = DATA + ".tar"