AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Do not force interrupt in test-debug/ProcessDebugMessagesThreaded.

Browse Source 
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/557773002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yangguo@chromium.org 2014-09-09 14:31:49 +00:00
parent bbd96b97e4
commit 8d6f9811da
1 changed files with 25 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
test/cctest/test-debug.cc
View File

@ -6531,9 +6531,25 @@ class SendCommandThread : public v8::base::Thread {
semaphore_(0),
isolate_(isolate) {}
static void ProcessDebugMessages(v8::Isolate* isolate, void* data) {
v8::Debug::ProcessDebugMessages();
reinterpret_cast<v8::base::Semaphore*>(data)->Signal();
class ClientDataImpl : public v8::Debug::ClientData {
public:
explicit ClientDataImpl(v8::base::Semaphore* semaphore)
: semaphore_(semaphore) {}
v8::base::Semaphore* semaphore() { return semaphore_; }
private:
v8::base::Semaphore* semaphore_;
};
static void CountingAndSignallingMessageHandler(
const v8::Debug::Message& message) {
if (message.IsResponse()) {
counting_message_handler_counter++;
ClientDataImpl* data =
reinterpret_cast<ClientDataImpl*>(message.GetClientData());
v8::base::Semaphore* semaphore = data->semaphore();
semaphore->Signal();
}
}
virtual void Run() {
@ -6550,18 +6566,16 @@ class SendCommandThread : public v8::base::Thread {
for (int i = 0; i < 100; i++) {
CHECK_EQ(i, counting_message_handler_counter);
// Queue debug message.
v8::Debug::SendCommand(isolate_, buffer, length);
// Synchronize with the main thread to force message processing.
isolate_->RequestInterrupt(ProcessDebugMessages, &semaphore_);
v8::Debug::SendCommand(isolate_, buffer, length,
new ClientDataImpl(&semaphore_));
// Wait for the message handler to pick up the response.
semaphore_.Wait();
}
v8::V8::TerminateExecution(isolate_);
}
void StartSending() {
semaphore_.Signal();
}
void StartSending() { semaphore_.Signal(); }
private:
v8::base::Semaphore semaphore_;
@ -6584,7 +6598,8 @@ TEST(ProcessDebugMessagesThreaded) {
counting_message_handler_counter = 0;
v8::Debug::SetMessageHandler(CountingMessageHandler);
v8::Debug::SetMessageHandler(
SendCommandThread::CountingAndSignallingMessageHandler);
send_command_thread_ = new SendCommandThread(isolate);
send_command_thread_->Start();