AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Use preserve_most calling conventions for Zone::NewExpand"

Browse Source 
This reverts commit 48fee7d232.

Reason for revert: Compile error: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20debug%20builder/6918/overview

Original change's description:
> Use preserve_most calling conventions for Zone::NewExpand
>
> The zone uses bump allocation in the fast-path, and falls back to
> allocating a new segment if there is not enough space.
> Since this is rarely executed and zone allocations happen a lot, we
> should mark `Zone::NewExpand` as "preserve_most" to make
> `Zone::Allocate` as fast and slim as possible.
>
> R=​bikineev@chromium.org, leszeks@chromium.org
>
> Change-Id: I0d592a35440bc3d61ca04425fc2f98c8a8bbbaae
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4146436
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Anton Bikineev <bikineev@chromium.org>
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#85258}

Change-Id: Id5d89bc8ae4f09b7bcd52e530b4ec69da550d683
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4162871
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#85261}
This commit is contained in:
Clemens Backes 2023-01-12 16:15:56 +00:00 committed by V8 LUCI CQ
parent 22c5844851
commit 8deececeef
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/zone/zone.h
View File

@ -235,7 +235,7 @@ class V8_EXPORT_PRIVATE Zone final {
// Expand the Zone to hold at least 'size' more bytes.
// Should only be called if there is not enough room in the Zone already.
V8_NOINLINE V8_PRESERVE_MOST void Expand(size_t size);
V8_NOINLINE void Expand(size_t size);
// The free region in the current (front) segment is represented as
// the half-open interval [position, limit). The 'position' variable