From 8ea947e64bf499aaaf407af8dc08ae4157308ddb Mon Sep 17 00:00:00 2001 From: "svenpanne@chromium.org" <svenpanne@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00> Date: Mon, 23 May 2011 07:00:54 +0000 Subject: [PATCH] Fixed pretty printing of typeof/delete/void expressions. Put spaces around binary operations and comparisons to improve readability. Review URL: http://codereview.chromium.org/7055008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/prettyprinter.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/prettyprinter.cc b/src/prettyprinter.cc index c777ab45b4..60288a969b 100644 --- a/src/prettyprinter.cc +++ b/src/prettyprinter.cc @@ -370,7 +370,10 @@ void PrettyPrinter::VisitCallRuntime(CallRuntime* node) { void PrettyPrinter::VisitUnaryOperation(UnaryOperation* node) { - Print("(%s", Token::String(node->op())); + Token::Value op = node->op(); + bool needsSpace = + op == Token::DELETE || op == Token::TYPEOF || op == Token::VOID; + Print("(%s%s", Token::String(op), needsSpace ? " " : ""); Visit(node->expression()); Print(")"); } @@ -388,7 +391,7 @@ void PrettyPrinter::VisitCountOperation(CountOperation* node) { void PrettyPrinter::VisitBinaryOperation(BinaryOperation* node) { Print("("); Visit(node->left()); - Print("%s", Token::String(node->op())); + Print(" %s ", Token::String(node->op())); Visit(node->right()); Print(")"); } @@ -397,7 +400,7 @@ void PrettyPrinter::VisitBinaryOperation(BinaryOperation* node) { void PrettyPrinter::VisitCompareOperation(CompareOperation* node) { Print("("); Visit(node->left()); - Print("%s", Token::String(node->op())); + Print(" %s ", Token::String(node->op())); Visit(node->right()); Print(")"); }