diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc index c489f7fec6..3ba3d6db50 100644 --- a/src/ia32/code-stubs-ia32.cc +++ b/src/ia32/code-stubs-ia32.cc @@ -5051,12 +5051,17 @@ void CEntryStub::GenerateCore(MacroAssembler* masm, __ dec(Operand::StaticVariable(scope_depth)); } - // Make sure we're not trying to return 'the hole' from the runtime - // call as this may lead to crashes in the IC code later. + // Runtime functions should not return 'the hole'. Allowing it to escape may + // lead to crashes in the IC code later. if (FLAG_debug_code) { Label okay; __ cmp(eax, masm->isolate()->factory()->the_hole_value()); __ j(not_equal, &okay, Label::kNear); + // TODO(wingo): Currently SuspendJSGeneratorObject returns the hole. Change + // to return another sentinel like a harmony symbol. + __ cmp(ebx, Immediate(ExternalReference( + Runtime::kSuspendJSGeneratorObject, masm->isolate()))); + __ j(equal, &okay, Label::kNear); __ int3(); __ bind(&okay); } diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index ad26fe6913..09097db9f5 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -34,9 +34,6 @@ bugs/*: FAIL # Fails. regress/regress-1119: FAIL -# TODO(wingo): Currently fails in no-snapshot mode, hence disabled for now. -harmony/generators-objects: SKIP - # Issue 1719: Slow to collect arrays over several contexts. regress/regress-524: SKIP # When that bug is fixed, revert the expectation to: