AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert of make ToLocalCheck crash in release mode (patchset #1 id:1 of https://codereview.chromium.org/1043363005/)

Browse Source 
Reason for revert:
breaks some devtools things

Original issue's description:
> make ToLocalCheck crash in release mode
>
> R=svenpanne@chromium.org
> BUG=
>
> Committed: https://crrev.com/ce7cc5119c1e031bf1eb8476fbf5e55bef738f94
> Cr-Commit-Position: refs/heads/master@{#27585}

TBR=svenpanne@chromium.org,machenbach@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1057873003

Cr-Commit-Position: refs/heads/master@{#27589}
This commit is contained in:
dcarney 2015-04-02 06:09:23 -07:00 committed by Commit bot
parent 9596b36c1d
commit 9038004932
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/v8.h
View File

@ -439,7 +439,7 @@ class MaybeLocal {
return !IsEmpty(); return !IsEmpty();
} }
// Will crash if the MaybeLocal<> is empty. // Will crash when checks are enabled if the MaybeLocal<> is empty.
V8_INLINE Local<T> ToLocalChecked(); V8_INLINE Local<T> ToLocalChecked();
template <class S> template <class S>
@ -6909,7 +6909,9 @@ Local<T> Eternal<T>::Get(Isolate* isolate) {
template <class T> template <class T>
Local<T> MaybeLocal<T>::ToLocalChecked() { Local<T> MaybeLocal<T>::ToLocalChecked() {
if (V8_UNLIKELY(val_ == nullptr)) V8::ToLocalEmpty(); #ifdef V8_ENABLE_CHECKS
if (val_ == nullptr) V8::ToLocalEmpty();
#endif
return Local<T>(val_); return Local<T>(val_);
} }