AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

PPC/AIX: Fixing parameter passing to builtins on AIX

Browse Source 
Extra parameters passed to a builtin function in AIX were undefined.
Issue had to do with using LoadP instead of lwz to load this FieldMemOperand.

Change-Id: Ia21b691c64bee2fec1b3f4ec24ca6518c5ae61d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687767
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#62511}
This commit is contained in:
Milad Farazmand 2019-07-03 08:43:00 -04:00 committed by Commit Bot
parent b55aec4409
commit 9056c1f801
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/ppc/builtins-ppc.cc
View File

@ -2396,7 +2396,7 @@ void Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
__ cmpli(r5, Operand(SharedFunctionInfo::kDontAdaptArgumentsSentinel));
__ beq(&dont_adapt_arguments);
__ LoadP(r7, FieldMemOperand(r4, JSFunction::kSharedFunctionInfoOffset));
__ LoadP(r7, FieldMemOperand(r7, SharedFunctionInfo::kFlagsOffset));
__ lwz(r7, FieldMemOperand(r7, SharedFunctionInfo::kFlagsOffset));
__ TestBitMask(r7, SharedFunctionInfo::IsSafeToSkipArgumentsAdaptorBit::kMask,
r0);
__ bne(&skip_adapt_arguments, cr0);