AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Only declare FATAL macro with arguments.

Browse Source 
The FATAL macro (without arguments) is used by some other libraries
e.g. protobuf and this causes conflicts. We only declared FATAL()
previously, so go back to that behavior by declaring arguments
for FATAL every time we define it.

Change-Id: Ia4c280fd7a1f27c2031de2fb691d60083f361a9a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1607649
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61440}
This commit is contained in:
Peter Marshall 2019-05-13 11:03:25 +02:00 committed by Commit Bot
parent b1e7cd9661
commit 90c003a394
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/base/logging.h
View File

@ -30,8 +30,7 @@ V8_BASE_EXPORT V8_NOINLINE void V8_Dcheck(const char* file, int line,
// passing in "", 0 for them. // passing in "", 0 for them.
[[noreturn]] PRINTF_FORMAT(1, 2) V8_BASE_EXPORT V8_NOINLINE [[noreturn]] PRINTF_FORMAT(1, 2) V8_BASE_EXPORT V8_NOINLINE
void V8_Fatal(const char* format, ...); void V8_Fatal(const char* format, ...);
#define FATAL V8_Fatal #define FATAL(...) V8_Fatal(__VA_ARGS__)
#else #else
// In official builds, include only messages that contain parameters because // In official builds, include only messages that contain parameters because
// single-message errors can always be derived from stack traces. // single-message errors can always be derived from stack traces.