[Interpreter] Fix missing entries for bytecode handlers in perf mapping.
Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/2085143003 Cr-Commit-Position: refs/heads/master@{#37224}
This commit is contained in:
parent
7b011fc9db
commit
91769d6464
@ -1596,8 +1596,9 @@ void Logger::LogBytecodeHandlers() {
|
||||
Code* code = interpreter->GetBytecodeHandler(bytecode, operand_scale);
|
||||
std::string bytecode_name =
|
||||
interpreter::Bytecodes::ToString(bytecode, operand_scale);
|
||||
CodeCreateEvent(CodeEventListener::BYTECODE_HANDLER_TAG,
|
||||
AbstractCode::cast(code), bytecode_name.c_str());
|
||||
PROFILE(isolate_, CodeCreateEvent(
|
||||
CodeEventListener::BYTECODE_HANDLER_TAG,
|
||||
AbstractCode::cast(code), bytecode_name.c_str()));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user