AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev] Correctly update the type in EnsureType

Browse Source 
We accidentally merged the static_type of the node into the runtime
info, rather than the runtime type we wanted to use.

Bug: v8:7700
Change-Id: Ief2f4887178a1b1f506a6a8b8be4d010a26eb92f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4197352
Auto-Submit: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85503}
This commit is contained in:
Toon Verwaest 2023-01-26 16:00:13 +01:00 committed by V8 LUCI CQ
parent 180bb8ef0d
commit 919166e9ef
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/maglev/maglev-graph-builder.cc
View File

@ -1428,7 +1428,7 @@ bool MaglevGraphBuilder::EnsureType(ValueNode* node, NodeType type,
NodeInfo* known_info = known_node_aspects().GetOrCreateInfoFor(node);
if (old_type) *old_type = known_info->type;
if (NodeTypeIs(known_info->type, type)) return true;
known_info->type = CombineType(known_info->type, static_type);
known_info->type = CombineType(known_info->type, type);
return false;
}