AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Fix small redundancy in register allocator per TODO.

Browse Source 
R=mtrofin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1690863006

Cr-Commit-Position: refs/heads/master@{#33957}
This commit is contained in:
titzer 2016-02-12 10:17:11 -08:00 committed by Commit bot
parent 821c603e0c
commit 92b9424ff3
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/compiler/register-allocator.cc
View File

@ -2442,12 +2442,15 @@ LifetimePosition RegisterAllocator::FindOptimalSplitPos(LifetimePosition start,
const InstructionBlock* block = end_block;
// Find header of outermost loop.
// TODO(titzer): fix redundancy below.
while (GetContainingLoop(code(), block) != nullptr &&
GetContainingLoop(code(), block)->rpo_number().ToInt() >
start_block->rpo_number().ToInt()) {
block = GetContainingLoop(code(), block);
do {
const InstructionBlock* loop = GetContainingLoop(code(), block);
if (loop == nullptr ||
loop->rpo_number().ToInt() <= start_block->rpo_number().ToInt()) {
// No more loops or loop starts before the lifetime start.
break;
}
block = loop;
} while (true);
// We did not find any suitable outer loop. Split at the latest possible
// position unless end_block is a loop header itself.