AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

MIPS64: Fix declaration for bit() function.

Browse Source 
From declarations of bit() member functions (for structures Register,
FPURegister and FPUControlRegister) are removed constexpr specificators.

Build V8 will fail if function bit() is declared as a constant
expression.

TEST=
BUG=

Review-Url: https://codereview.chromium.org/2737143002
Cr-Commit-Position: refs/heads/master@{#43674}
This commit is contained in:
Ilija.Pavlovic 2017-03-08 07:09:16 -08:00 committed by Commit bot
parent 65a07b7a10
commit 92da406213
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/mips64/assembler-mips64.h
View File

@ -132,7 +132,10 @@ struct Register {
DCHECK(is_valid());
return reg_code;
}
constexpr int bit() const { return DCHECK(is_valid()), 1 << reg_code; }
int bit() const {
DCHECK(is_valid());
return 1 << reg_code;
}
// Unfortunately we can't make this private in a struct.
int reg_code;
@ -196,7 +199,11 @@ struct FPURegister {
DCHECK(is_valid());
return reg_code;
}
constexpr int bit() const { return DCHECK(is_valid()), 1 << reg_code; }
int bit() const {
DCHECK(is_valid());
return 1 << reg_code;
}
static FPURegister from_code(int code) {
FPURegister r = {code};
@ -287,7 +294,10 @@ struct FPUControlRegister {
DCHECK(is_valid());
return reg_code;
}
constexpr int bit() const { return DCHECK(is_valid()), 1 << reg_code; }
int bit() const {
DCHECK(is_valid());
return 1 << reg_code;
}
void setcode(int f) {
reg_code = f;
DCHECK(is_valid());