[presubmit] Fix build/include linter violations.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1318863004

Cr-Commit-Position: refs/heads/master@{#30554}

include/v8-debug.h

@@ -5,7 +5,7 @@
 #ifndef V8_V8_DEBUG_H_
 #define V8_V8_DEBUG_H_
 
-#include "v8.h"
+#include "v8.h"  // NOLINT(build/include)
 
 /**
  * Debugger support for the V8 JavaScript engine.

include/v8-profiler.h

@@ -6,7 +6,7 @@
 #define V8_V8_PROFILER_H_
 
 #include <vector>
-#include "v8.h"
+#include "v8.h"  // NOLINT(build/include)
 
 /**
  * Profiler support for the V8 JavaScript engine.

include/v8-testing.h

@@ -5,7 +5,7 @@
 #ifndef V8_V8_TEST_H_
 #define V8_V8_TEST_H_
 
-#include "v8.h"
+#include "v8.h"  // NOLINT(build/include)
 
 /**
  * Testing support for the V8 JavaScript engine.

include/v8-util.h

@@ -5,7 +5,7 @@
 #ifndef V8_UTIL_H_
 #define V8_UTIL_H_
 
-#include "v8.h"
+#include "v8.h"  // NOLINT(build/include)
 #include <map>
 #include <vector>
 

include/v8.h

@@ -19,8 +19,8 @@
 #include <stdint.h>
 #include <stdio.h>
 
-#include "v8-version.h"
-#include "v8config.h"
+#include "v8-version.h"  // NOLINT(build/include)
+#include "v8config.h"    // NOLINT(build/include)
 
 // We reserve the V8_* prefix for macros defined in V8 public API and
 // assume there are no name conflicts with the embedder's code.

src/arm/assembler-arm.cc

@@ -34,6 +34,8 @@
 // modified significantly by Google Inc.
 // Copyright 2012 the V8 project authors. All rights reserved.
 
+#include "src/arm/assembler-arm.h"
+
 #if V8_TARGET_ARCH_ARM
 
 #include "src/arm/assembler-arm-inl.h"

src/arm/code-stubs-arm.cc

@@ -16,6 +16,8 @@
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"
 
+#include "src/arm/code-stubs-arm.h"
+
 namespace v8 {
 namespace internal {
 

src/arm/codegen-arm.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm/codegen-arm.h"
+
 #if V8_TARGET_ARCH_ARM
 
 #include "src/arm/simulator-arm.h"

src/arm/frames-arm.cc

@@ -10,6 +10,7 @@
 
 #include "src/arm/assembler-arm-inl.h"
 #include "src/arm/assembler-arm.h"
+#include "src/arm/frames-arm.h"
 #include "src/arm/macro-assembler-arm.h"
 
 namespace v8 {

src/arm/interface-descriptors-arm.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm/interface-descriptors-arm.h"
+
 #if V8_TARGET_ARCH_ARM
 
 #include "src/interface-descriptors.h"

src/arm/lithium-arm.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm/lithium-arm.h"
+
 #include <sstream>
 
 #include "src/arm/lithium-codegen-arm.h"

src/arm/macro-assembler-arm.cc

@@ -14,6 +14,8 @@
 #include "src/debug/debug.h"
 #include "src/runtime/runtime.h"
 
+#include "src/arm/macro-assembler-arm.h"
+
 namespace v8 {
 namespace internal {
 

src/arm64/assembler-arm64.cc

@@ -29,6 +29,7 @@
 #if V8_TARGET_ARCH_ARM64
 
 #define ARM64_DEFINE_REG_STATICS
+#include "src/arm64/assembler-arm64.h"
 
 #include "src/arm64/assembler-arm64-inl.h"
 #include "src/arm64/frames-arm64.h"

src/arm64/code-stubs-arm64.cc

@@ -4,7 +4,6 @@
 
 #if V8_TARGET_ARCH_ARM64
 
-#include "src/arm64/frames-arm64.h"
 #include "src/bootstrapper.h"
 #include "src/code-stubs.h"
 #include "src/codegen.h"
@@ -16,6 +15,9 @@
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"
 
+#include "src/arm64/code-stubs-arm64.h"
+#include "src/arm64/frames-arm64.h"
+
 namespace v8 {
 namespace internal {
 

src/arm64/codegen-arm64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm64/codegen-arm64.h"
+
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/arm64/simulator-arm64.h"

src/arm64/frames-arm64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm64/frames-arm64.h"
+
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/arm64/assembler-arm64-inl.h"

src/arm64/interface-descriptors-arm64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm64/interface-descriptors-arm64.h"
+
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/interface-descriptors.h"

src/arm64/lithium-arm64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/arm64/lithium-arm64.h"
+
 #include <sstream>
 
 #include "src/arm64/lithium-codegen-arm64.h"

src/arm64/macro-assembler-arm64.cc

@@ -4,7 +4,6 @@
 
 #if V8_TARGET_ARCH_ARM64
 
-#include "src/arm64/frames-arm64.h"
 #include "src/base/bits.h"
 #include "src/base/division-by-constant.h"
 #include "src/bootstrapper.h"
@@ -13,6 +12,9 @@
 #include "src/debug/debug.h"
 #include "src/runtime/runtime.h"
 
+#include "src/arm64/frames-arm64.h"
+#include "src/arm64/macro-assembler-arm64.h"
+
 namespace v8 {
 namespace internal {
 

src/base/atomicops_internals_x86_gcc.cc

@@ -5,7 +5,7 @@
 // This module gets enough CPU information to optimize the
 // atomicops module on x86.
 
-#include <string.h>
+#include <string.h>  // NOLINT(build/include)
 
 #include "src/base/atomicops.h"
 

src/base/platform/platform-freebsd.cc

@@ -17,7 +17,6 @@
 #include <sys/fcntl.h>  // open
 #include <sys/mman.h>   // mmap & munmap
 #include <sys/stat.h>   // open
-#include <sys/types.h>  // mmap & munmap
 #include <unistd.h>     // getpagesize
 // If you don't have execinfo.h then you need devel/libexecinfo from ports.
 #include <errno.h>

src/base/platform/platform-openbsd.cc

@@ -20,7 +20,6 @@
 #include <strings.h>    // index
 #include <sys/mman.h>   // mmap & munmap
 #include <sys/stat.h>   // open
-#include <sys/types.h>  // mmap & munmap
 #include <unistd.h>     // sysconf
 
 #include <cmath>

src/base/platform/platform-qnx.cc

@@ -24,7 +24,6 @@
 #include <sys/mman.h>   // mmap & munmap
 #include <sys/procfs.h>
 #include <sys/stat.h>   // open
-#include <sys/types.h>  // mmap & munmap
 #include <unistd.h>     // sysconf
 
 #include <cmath>

src/compiler/control-builders.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "control-builders.h"
+#include "src/compiler/control-builders.h"
 
 namespace v8 {
 namespace internal {

src/compiler/simplified-lowering.cc

@@ -15,7 +15,6 @@
 #include "src/compiler/node-properties.h"
 #include "src/compiler/operator-properties.h"
 #include "src/compiler/representation-change.h"
-#include "src/compiler/simplified-lowering.h"
 #include "src/compiler/simplified-operator.h"
 #include "src/compiler/source-position.h"
 #include "src/objects.h"

src/flags.cc

@@ -21,11 +21,11 @@ namespace internal {
 
 // Define all of our flags.
 #define FLAG_MODE_DEFINE
-#include "src/flag-definitions.h"  // NOLINT
+#include "src/flag-definitions.h"  // NOLINT(build/include)
 
 // Define all of our flags default values.
 #define FLAG_MODE_DEFINE_DEFAULTS
-#include "src/flag-definitions.h"  // NOLINT
+#include "src/flag-definitions.h"  // NOLINT(build/include)
 
 namespace {
 
@@ -164,7 +164,7 @@ struct Flag {
 
 Flag flags[] = {
 #define FLAG_MODE_META
-#include "src/flag-definitions.h"
+#include "src/flag-definitions.h"  // NOLINT(build/include)
 };
 
 const size_t num_flags = sizeof(flags) / sizeof(*flags);
@@ -570,7 +570,7 @@ void ComputeFlagListHash() {
 // static
 void FlagList::EnforceFlagImplications() {
 #define FLAG_MODE_DEFINE_IMPLICATIONS
-#include "src/flag-definitions.h"
+#include "src/flag-definitions.h"  // NOLINT(build/include)
 #undef FLAG_MODE_DEFINE_IMPLICATIONS
   ComputeFlagListHash();
 }

src/ia32/code-stubs-ia32.cc

@@ -8,6 +8,7 @@
 #include "src/bootstrapper.h"
 #include "src/code-stubs.h"
 #include "src/codegen.h"
+#include "src/ia32/code-stubs-ia32.h"
 #include "src/ia32/frames-ia32.h"
 #include "src/ic/handler-compiler.h"
 #include "src/ic/ic.h"

src/ia32/codegen-ia32.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/ia32/codegen-ia32.h"
+
 #if V8_TARGET_ARCH_IA32
 
 #include "src/codegen.h"

src/ia32/frames-ia32.cc

@@ -8,6 +8,7 @@
 #include "src/frames.h"
 #include "src/ia32/assembler-ia32-inl.h"
 #include "src/ia32/assembler-ia32.h"
+#include "src/ia32/frames-ia32.h"
 
 namespace v8 {
 namespace internal {

src/ia32/lithium-ia32.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/ia32/lithium-ia32.h"
+
 #include <sstream>
 
 #if V8_TARGET_ARCH_IA32

src/ia32/macro-assembler-ia32.cc

@@ -11,6 +11,7 @@
 #include "src/cpu-profiler.h"
 #include "src/debug/debug.h"
 #include "src/ia32/frames-ia32.h"
+#include "src/ia32/macro-assembler-ia32.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {

src/ia32/simulator-ia32.cc

@@ -2,5 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/ia32/simulator-ia32.h"
 
 // Since there is no simulator for the ia32 architecture this file is empty.

src/mips/assembler-mips.cc

@@ -32,6 +32,8 @@
 // modified significantly by Google Inc.
 // Copyright 2012 the V8 project authors. All rights reserved.
 
+#include "src/mips/assembler-mips.h"
+
 #if V8_TARGET_ARCH_MIPS
 
 #include "src/base/bits.h"

src/mips/code-stubs-mips.cc

@@ -12,6 +12,7 @@
 #include "src/ic/ic.h"
 #include "src/ic/stub-cache.h"
 #include "src/isolate.h"
+#include "src/mips/code-stubs-mips.h"
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"

src/mips/codegen-mips.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/mips/codegen-mips.h"
+
 #if V8_TARGET_ARCH_MIPS
 
 #include "src/codegen.h"

src/mips/frames-mips.cc

@@ -8,6 +8,7 @@
 #include "src/frames.h"
 #include "src/mips/assembler-mips-inl.h"
 #include "src/mips/assembler-mips.h"
+#include "src/mips/frames-mips.h"
 
 namespace v8 {
 namespace internal {

src/mips/lithium-mips.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/mips/lithium-mips.h"
+
 #include <sstream>
 
 #if V8_TARGET_ARCH_MIPS

src/mips/macro-assembler-mips.cc

@@ -12,6 +12,7 @@
 #include "src/codegen.h"
 #include "src/cpu-profiler.h"
 #include "src/debug/debug.h"
+#include "src/mips/macro-assembler-mips.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {

src/mips64/assembler-mips64.cc

@@ -32,6 +32,8 @@
 // modified significantly by Google Inc.
 // Copyright 2012 the V8 project authors. All rights reserved.
 
+#include "src/mips64/assembler-mips64.h"
+
 #if V8_TARGET_ARCH_MIPS64
 
 #include "src/base/cpu.h"

src/mips64/code-stubs-mips64.cc

@@ -11,6 +11,7 @@
 #include "src/ic/ic.h"
 #include "src/ic/stub-cache.h"
 #include "src/isolate.h"
+#include "src/mips64/code-stubs-mips64.h"
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"

src/mips64/codegen-mips64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/mips64/codegen-mips64.h"
+
 #if V8_TARGET_ARCH_MIPS64
 
 #include "src/codegen.h"

src/mips64/frames-mips64.cc

@@ -8,6 +8,7 @@
 #include "src/frames.h"
 #include "src/mips64/assembler-mips64-inl.h"
 #include "src/mips64/assembler-mips64.h"
+#include "src/mips64/frames-mips64.h"
 
 namespace v8 {
 namespace internal {

src/mips64/lithium-mips64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/mips64/lithium-mips64.h"
+
 #include <sstream>
 
 #if V8_TARGET_ARCH_MIPS64

src/mips64/macro-assembler-mips64.cc

@@ -11,6 +11,7 @@
 #include "src/codegen.h"
 #include "src/cpu-profiler.h"
 #include "src/debug/debug.h"
+#include "src/mips64/macro-assembler-mips64.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {

src/ppc/assembler-ppc.cc

@@ -34,6 +34,8 @@
 // modified significantly by Google Inc.
 // Copyright 2014 the V8 project authors. All rights reserved.
 
+#include "src/ppc/assembler-ppc.h"
+
 #if V8_TARGET_ARCH_PPC
 
 #include "src/base/bits.h"

src/ppc/code-stubs-ppc.cc

@@ -12,6 +12,7 @@
 #include "src/ic/ic.h"
 #include "src/ic/stub-cache.h"
 #include "src/isolate.h"
+#include "src/ppc/code-stubs-ppc.h"
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"

src/ppc/codegen-ppc.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/ppc/codegen-ppc.h"
+
 #if V8_TARGET_ARCH_PPC
 
 #include "src/codegen.h"

src/ppc/frames-ppc.cc

@@ -10,6 +10,7 @@
 
 #include "src/ppc/assembler-ppc.h"
 #include "src/ppc/assembler-ppc-inl.h"
+#include "src/ppc/frames-ppc.h"
 #include "src/ppc/macro-assembler-ppc.h"
 
 namespace v8 {

src/ppc/lithium-ppc.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/ppc/lithium-ppc.h"
+
 #include <sstream>
 
 #include "src/hydrogen-osr.h"

src/ppc/macro-assembler-ppc.cc

@@ -13,6 +13,7 @@
 #include "src/codegen.h"
 #include "src/cpu-profiler.h"
 #include "src/debug/debug.h"
+#include "src/ppc/macro-assembler-ppc.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {

src/runtime/runtime-regexp.cc

@@ -10,7 +10,6 @@
 #include "src/messages.h"
 #include "src/regexp/jsregexp-inl.h"
 #include "src/regexp/jsregexp.h"
-#include "src/runtime/runtime-utils.h"
 #include "src/string-builder.h"
 #include "src/string-search.h"
 

src/unicode.cc

@@ -4,6 +4,7 @@
 //
 // This file was generated at 2014-10-08 15:25:47.940335
 
+#include "src/unicode.h"
 #include "src/unicode-inl.h"
 #include <stdio.h>
 #include <stdlib.h>

src/x64/code-stubs-x64.cc

@@ -14,6 +14,7 @@
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"
+#include "src/x64/code-stubs-x64.h"
 
 namespace v8 {
 namespace internal {

src/x64/codegen-x64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/x64/codegen-x64.h"
+
 #if V8_TARGET_ARCH_X64
 
 #include "src/codegen.h"

src/x64/frames-x64.cc

@@ -8,6 +8,7 @@
 #include "src/frames.h"
 #include "src/x64/assembler-x64-inl.h"
 #include "src/x64/assembler-x64.h"
+#include "src/x64/frames-x64.h"
 
 namespace v8 {
 namespace internal {

src/x64/lithium-x64.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/x64/lithium-x64.h"
+
 #include <sstream>
 
 #if V8_TARGET_ARCH_X64

src/x64/simulator-x64.cc

@@ -1,3 +1,5 @@
 // Copyright 2009 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
+
+#include "src/x64/simulator-x64.h"

src/x87/assembler-x87.cc

@@ -34,6 +34,8 @@
 // significantly by Google Inc.
 // Copyright 2012 the V8 project authors. All rights reserved.
 
+#include "src/x87/assembler-x87.h"
+
 #if V8_TARGET_ARCH_X87
 
 #include "src/base/bits.h"

src/x87/code-stubs-x87.cc

@@ -15,6 +15,7 @@
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-macro-assembler.h"
 #include "src/runtime/runtime.h"
+#include "src/x87/code-stubs-x87.h"
 #include "src/x87/frames-x87.h"
 
 namespace v8 {

src/x87/codegen-x87.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/x87/codegen-x87.h"
+
 #if V8_TARGET_ARCH_X87
 
 #include "src/codegen.h"

src/x87/frames-x87.cc

@@ -8,6 +8,7 @@
 #include "src/frames.h"
 #include "src/x87/assembler-x87-inl.h"
 #include "src/x87/assembler-x87.h"
+#include "src/x87/frames-x87.h"
 
 namespace v8 {
 namespace internal {

src/x87/lithium-x87.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/x87/lithium-x87.h"
+
 #include <sstream>
 
 #if V8_TARGET_ARCH_X87

src/x87/macro-assembler-x87.cc

@@ -12,6 +12,7 @@
 #include "src/debug/debug.h"
 #include "src/runtime/runtime.h"
 #include "src/x87/frames-x87.h"
+#include "src/x87/macro-assembler-x87.h"
 
 namespace v8 {
 namespace internal {

src/x87/simulator-x87.cc

@@ -2,5 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/x87/simulator-x87.h"
 
 // Since there is no simulator for the ia32 architecture this file is empty.

test/cctest/test-typedarrays.cc

@@ -10,7 +10,6 @@
 #include "src/api.h"
 #include "src/heap/heap.h"
 #include "src/objects.h"
-#include "src/v8.h"
 
 using namespace v8::internal;
 

tools/presubmit.py

@@ -50,13 +50,11 @@ from subprocess import PIPE
 # build/include_what_you_use: Started giving false positives for variables
 #   named "string" and "map" assuming that you needed to include STL headers.
 # TODO(bmeurer): Fix and re-enable readability/check
-# TODO(mstarzinger): Fix and re-enable build/include
 # TODO(mstarzinger): Fix and re-enable readability/namespace
 
 LINT_RULES = """
 -build/c++11
 -build/header_guard
--build/include
 +build/include_alpha
 -build/include_what_you_use
 -build/namespaces