From 93165a6721d0e5000a5af580528f10ed11a906c1 Mon Sep 17 00:00:00 2001 From: Leszek Swirski Date: Tue, 10 Jan 2023 17:15:54 +0100 Subject: [PATCH] [maglev] Add maglev config to foozzie Bug: v8:7700 Change-Id: I2e20d457e303bf4cd4338ff45bb47c8f863885c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4152473 Commit-Queue: Michael Achenbach Reviewed-by: Michael Achenbach Auto-Submit: Leszek Swirski Cr-Commit-Position: refs/heads/main@{#85209} --- tools/clusterfuzz/foozzie/testdata/failure_output.txt | 2 +- .../clusterfuzz/foozzie/testdata/failure_output_arch.txt | 2 +- .../foozzie/testdata/failure_output_second.txt | 2 +- tools/clusterfuzz/foozzie/testdata/smoke_test_output.txt | 2 +- tools/clusterfuzz/foozzie/v8_foozzie.py | 9 +++++++++ tools/clusterfuzz/foozzie/v8_fuzz_experiments.json | 9 +++++---- 6 files changed, 18 insertions(+), 8 deletions(-) diff --git a/tools/clusterfuzz/foozzie/testdata/failure_output.txt b/tools/clusterfuzz/foozzie/testdata/failure_output.txt index 9d00ca4586..8be71d9db2 100644 --- a/tools/clusterfuzz/foozzie/testdata/failure_output.txt +++ b/tools/clusterfuzz/foozzie/testdata/failure_output.txt @@ -9,7 +9,7 @@ # Compared x64,ignition with x64,ignition_turbo # # Flags of x64,ignition: ---correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up --flag1 --flag2=0 +--correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up --no-maglev --flag1 --flag2=0 # Flags of x64,ignition_turbo: --correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --flag3 # diff --git a/tools/clusterfuzz/foozzie/testdata/failure_output_arch.txt b/tools/clusterfuzz/foozzie/testdata/failure_output_arch.txt index 9f6f9edad4..1d75ba592b 100644 --- a/tools/clusterfuzz/foozzie/testdata/failure_output_arch.txt +++ b/tools/clusterfuzz/foozzie/testdata/failure_output_arch.txt @@ -9,7 +9,7 @@ # Compared x64,ignition with x64,ignition_turbo # # Flags of x64,ignition: ---correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up +--correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up --no-maglev # Flags of x64,ignition_turbo: --correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --bad-flag # diff --git a/tools/clusterfuzz/foozzie/testdata/failure_output_second.txt b/tools/clusterfuzz/foozzie/testdata/failure_output_second.txt index 6deccfb8fa..2a8097fb39 100644 --- a/tools/clusterfuzz/foozzie/testdata/failure_output_second.txt +++ b/tools/clusterfuzz/foozzie/testdata/failure_output_second.txt @@ -9,7 +9,7 @@ # Compared x64,ignition with ia32,ignition_turbo # # Flags of x64,ignition: ---correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up +--correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up --no-maglev # Flags of ia32,ignition_turbo: --correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --very-bad-flag # diff --git a/tools/clusterfuzz/foozzie/testdata/smoke_test_output.txt b/tools/clusterfuzz/foozzie/testdata/smoke_test_output.txt index e322801c9f..11aa471e52 100644 --- a/tools/clusterfuzz/foozzie/testdata/smoke_test_output.txt +++ b/tools/clusterfuzz/foozzie/testdata/smoke_test_output.txt @@ -9,7 +9,7 @@ # Compared x64,ignition with x64,ignition_turbo # # Flags of x64,ignition: ---correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up +--correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --no-turbofan --no-sparkplug --liftoff --no-wasm-tier-up --no-maglev # Flags of x64,ignition_turbo: --correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --harmony --wasm-staging --no-wasm-async-compilation --wasm-max-mem-pages=32767 --suppress-asm-messages --random-seed 12345 # diff --git a/tools/clusterfuzz/foozzie/v8_foozzie.py b/tools/clusterfuzz/foozzie/v8_foozzie.py index 9199e8758f..a6c12bf308 100755 --- a/tools/clusterfuzz/foozzie/v8_foozzie.py +++ b/tools/clusterfuzz/foozzie/v8_foozzie.py @@ -35,6 +35,7 @@ CONFIGS = dict( '--no-sparkplug', '--liftoff', '--no-wasm-tier-up', + '--no-maglev', ], ignition_asm=[ '--turbo-filter=~', @@ -42,6 +43,7 @@ CONFIGS = dict( '--no-sparkplug', '--validate-asm', '--stress-validate-asm', + '--no-maglev', ], ignition_eager=[ '--turbo-filter=~', @@ -49,6 +51,7 @@ CONFIGS = dict( '--no-sparkplug', '--no-lazy', '--no-lazy-inner-functions', + '--no-maglev', ], ignition_no_ic=[ '--turbo-filter=~', @@ -58,6 +61,7 @@ CONFIGS = dict( '--no-wasm-tier-up', '--no-use-ic', '--no-lazy-feedback-allocation', + '--no-maglev', ], ignition_turbo=[], ignition_turbo_no_ic=[ @@ -72,6 +76,11 @@ CONFIGS = dict( '--no-lazy', '--no-lazy-inner-functions', ], + ignition_maglev=[ + '--maglev', + '--turbo-filter=~', + '--no-turbofan', + ], jitless=[ '--jitless', ], diff --git a/tools/clusterfuzz/foozzie/v8_fuzz_experiments.json b/tools/clusterfuzz/foozzie/v8_fuzz_experiments.json index 8c6baa2496..ff38b5f711 100644 --- a/tools/clusterfuzz/foozzie/v8_fuzz_experiments.json +++ b/tools/clusterfuzz/foozzie/v8_fuzz_experiments.json @@ -1,15 +1,16 @@ [ - [15, "ignition", "jitless", "d8"], + [10, "ignition", "jitless", "d8"], [10, "ignition", "slow_path", "d8"], - [10, "ignition_no_ic", "slow_path", "d8"], + [5, "ignition_no_ic", "slow_path", "d8"], [5, "ignition", "slow_path_opt", "d8"], [5, "ignition", "ignition_turbo_no_ic", "d8"], - [20, "ignition", "ignition_turbo_opt", "d8"], + [15, "ignition", "ignition_turbo_opt", "d8"], [5, "ignition_no_ic", "ignition_turbo_opt", "d8"], + [15, "ignition", "ignition_maglev", "d8"], [5, "ignition_turbo", "ignition_turbo_opt", "clang_x64_pointer_compression/d8"], [5, "ignition", "ignition", "clang_x86/d8"], [5, "ignition", "ignition_turbo_opt", "clang_x86/d8"], [5, "ignition", "slow_path", "clang_x86/d8"], [5, "ignition", "ignition_turbo_opt", "clang_x64_v8_arm64/d8"], [5, "ignition", "ignition_turbo_opt", "clang_x86_v8_arm/d8"] -] \ No newline at end of file +]