AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[ast] Clean up a few unnecessary bits in AST

Browse Source 
R=verwaest@chromium.org

Review-Url: https://codereview.chromium.org/2248813002
Cr-Commit-Position: refs/heads/master@{#38641}
This commit is contained in:
adamk 2016-08-15 13:53:05 -07:00 committed by Commit bot
parent 1153621249
commit 9349243506
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ast/ast.h
View File

@ -220,8 +220,6 @@ class AstNode: public ZoneObject {
// current zone from the TLS.
void* operator new(size_t size);
friend class CaseClause; // Generates AST IDs.
int position_;
NodeType node_type_;
// Ends with NodeType which is uint8_t sized. Deriving classes in turn begin
@ -1580,8 +1578,6 @@ class VariableProxy final : public Expression {
return !is_this() && !is_new_target();
}
bool IsArguments() const { return is_resolved() && var()->is_arguments(); }
Handle<String> name() const { return raw_name()->string(); }
const AstRawString* raw_name() const {
return is_resolved() ? var_->raw_name() : raw_name_;
@ -1651,8 +1647,6 @@ class VariableProxy final : public Expression {
class IsResolvedField : public BitField8<bool, 2, 1> {};
class IsNewTargetField : public BitField8<bool, 3, 1> {};
// Start with 16-bit (or smaller) field, which should get packed together
// with Expression's trailing 16-bit field.
uint8_t bit_field_;
// Position is stored in the AstNode superclass, but VariableProxy needs to
// know its end position too (for error messages). It cannot be inferred from

2
src/crankshaft/hydrogen.cc
View File

@ -7085,7 +7085,7 @@ void HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {
}
}
if (proxy->IsArguments()) return Bailout(kAssignmentToArguments);
if (var->is_arguments()) return Bailout(kAssignmentToArguments);
// Handle the assignment.
switch (var->location()) {