AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Enable --shared-space flag by default

Browse Source 
This switches V8 to the shared space isolate approach for the shared
heap by default.

Bug: v8:13267
Change-Id: I06d36468a3a6b098475ec2bbfa998cb1934afe81
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3925754
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83701}
This commit is contained in:
Dominik Inführ 2022-10-13 09:37:04 +02:00 committed by V8 LUCI CQ
parent 508e7e73e0
commit 934afdf0d1
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flags/flag-definitions.h
View File

@ -1240,7 +1240,7 @@ DEFINE_BOOL(separate_gc_phases, false,
DEFINE_BOOL(global_gc_scheduling, true, DEFINE_BOOL(global_gc_scheduling, true,
"enable GC scheduling based on global memory") "enable GC scheduling based on global memory")
DEFINE_BOOL(gc_global, false, "always perform global GCs") DEFINE_BOOL(gc_global, false, "always perform global GCs")
DEFINE_BOOL(shared_space, false, DEFINE_BOOL(shared_space, true,
"Implement shared heap as shared space on a main isolate.") "Implement shared heap as shared space on a main isolate.")
// Don't use a map space with --shared-space in order to avoid shared map space. // Don't use a map space with --shared-space in order to avoid shared map space.
DEFINE_NEG_IMPLICATION(shared_space, use_map_space) DEFINE_NEG_IMPLICATION(shared_space, use_map_space)

3
src/heap/heap.cc
View File

@ -6159,7 +6159,8 @@ void Heap::ClearRecordedSlotRange(Address start, Address end) {
Page* page = Page::FromAddress(start); Page* page = Page::FromAddress(start);
DCHECK(!page->IsLargePage()); DCHECK(!page->IsLargePage());
if (!page->InYoungGeneration()) { if (!page->InYoungGeneration()) {
DCHECK_EQ(page->owner_identity(), OLD_SPACE); DCHECK(page->owner_identity() == OLD_SPACE ||
page->owner_identity() == SHARED_SPACE);
if (!page->SweepingDone()) { if (!page->SweepingDone()) {
RememberedSet<OLD_TO_NEW>::RemoveRange(page, start, end, RememberedSet<OLD_TO_NEW>::RemoveRange(page, start, end,