AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Disable V8 snapshot on 32-bit win/cross builds

Browse Source 
Clang crashes in this configuration.  See https://crbug.com/942347 for context.

BUG=chromium:942347
R=machenbach
CC=thakis

Change-Id: Iffcad9556ed92ecfbd4ee062a5ed7f8c8cac1914
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524639
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60258}
This commit is contained in:
Tom Anderson 2019-03-14 17:09:21 -07:00 committed by Commit Bot
parent fb701a9a2f
commit 93ee541417
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gni/v8.gni
View File

@ -37,9 +37,10 @@ declare_args() {
# Enable the snapshot feature, for fast context creation.
# https://v8.dev/blog/custom-startup-snapshots
# TODO(thakis): Make snapshots work in 64-bit win/cross builds,
# https://803591
v8_use_snapshot = !(is_win && host_os != "win" && target_cpu == "x64")
# TODO(thakis): Make snapshots work in 64-bit win/cross builds
# (https://crbug.com/803591) and 32-bit win/cross builds
# (https://crbug.com/942347)
v8_use_snapshot = !is_win || host_os == "win"
# Enable several snapshots side-by-side (e.g. default and for trusted code).
v8_use_multi_snapshots = false