AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[sandbox] Update test/mkgrokdump/README

Browse Source 
When regenerating v8heapconst.py, the v8 sandbox now has to be enabled
explicitly (using the v8_enabe_sandbox=true gn arg) as it is enabled by
default in Chromium builds, but not standalone v8 builds.

Bug: v8:13281
Change-Id: I1a0861b1d63f340465d7433e042b27eace706ca7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3895622
Commit-Queue: Adam Klein <adamk@chromium.org>
Auto-Submit: Samuel Groß <saelo@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83201}
This commit is contained in:
Samuel Groß 2022-09-14 12:10:22 +00:00 committed by V8 LUCI CQ
parent 429f959f3d
commit 95216968f5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/mkgrokdump/README
View File

@ -1,3 +1,5 @@
If you change the heap layout, expect this test to fail (in CQ). You will then
need to build x64 release and run `<outdir>/mkgrokdump > tools/v8heapconst.py`
to rebaseline.
need to build x64 release with v8_enable_sandbox=true and run
`<outdir>/mkgrokdump > tools/v8heapconst.py` to rebaseline.
The V8 sandbox has to be manually enabled as it is enabled by default only for
Chromium builds, but not standalone v8 builds.