AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] Remove obsolete V8DebuggerScript::isSourceLoadedLazily().

Browse Source 
This was originally introduced to address http://crbug.com/794941,
to make the disassembly generation for WebAssembly modules lazy.
Nowadays we no longer generate a text representation for the Wasm
disassembly in V8, and this method always returns `false`.

Bug: chromium:794941, chromium:1162229
Change-Id: I8b67e451a3657bf732615585577525aeea2b2f55
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494236
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79304}
This commit is contained in:
Benedikt Meurer 2022-02-28 09:16:08 +01:00 committed by V8 LUCI CQ
parent 99c247fb78
commit 95c4483120
3 changed files with 8 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/inspector/v8-debugger-agent-impl.cc
View File

@ -1588,7 +1588,6 @@ void V8DebuggerAgentImpl::didParseSource(
std::unique_ptr<V8DebuggerScript> script, bool success) { std::unique_ptr<V8DebuggerScript> script, bool success) {
v8::HandleScope handles(m_isolate); v8::HandleScope handles(m_isolate);
if (!success) { if (!success) {
DCHECK(!script->isSourceLoadedLazily());
String16 scriptSource = script->source(0); String16 scriptSource = script->source(0);
script->setSourceURL(findSourceURL(scriptSource, false)); script->setSourceURL(findSourceURL(scriptSource, false));
script->setSourceMappingURL(findSourceMapURL(scriptSource, false)); script->setSourceMappingURL(findSourceMapURL(scriptSource, false));
@ -1663,23 +1662,14 @@ void V8DebuggerAgentImpl::didParseSource(
return; return;
} }
if (scriptRef->isSourceLoadedLazily()) { m_frontend.scriptParsed(
m_frontend.scriptParsed( scriptId, scriptURL, scriptRef->startLine(), scriptRef->startColumn(),
scriptId, scriptURL, 0, 0, 0, 0, contextId, scriptRef->hash(), scriptRef->endLine(), scriptRef->endColumn(), contextId,
std::move(executionContextAuxDataParam), isLiveEditParam, scriptRef->hash(), std::move(executionContextAuxDataParam),
std::move(sourceMapURLParam), hasSourceURLParam, isModuleParam, 0, isLiveEditParam, std::move(sourceMapURLParam), hasSourceURLParam,
std::move(stackTrace), std::move(codeOffset), std::move(scriptLanguage), isModuleParam, scriptRef->length(), std::move(stackTrace),
std::move(debugSymbols), embedderName); std::move(codeOffset), std::move(scriptLanguage), std::move(debugSymbols),
} else { embedderName);
m_frontend.scriptParsed(
scriptId, scriptURL, scriptRef->startLine(), scriptRef->startColumn(),
scriptRef->endLine(), scriptRef->endColumn(), contextId,
scriptRef->hash(), std::move(executionContextAuxDataParam),
isLiveEditParam, std::move(sourceMapURLParam), hasSourceURLParam,
isModuleParam, scriptRef->length(), std::move(stackTrace),
std::move(codeOffset), std::move(scriptLanguage),
std::move(debugSymbols), embedderName);
}
std::vector<protocol::DictionaryValue*> potentialBreakpoints; std::vector<protocol::DictionaryValue*> potentialBreakpoints;
if (!scriptURL.isEmpty()) { if (!scriptURL.isEmpty()) {

1
src/inspector/v8-debugger-script.cc
View File

@ -156,7 +156,6 @@ class ActualScript : public V8DebuggerScript {
#endif // V8_ENABLE_WEBASSEMBLY #endif // V8_ENABLE_WEBASSEMBLY
return 0; return 0;
} }
bool isSourceLoadedLazily() const override { return false; }
int length() const override { int length() const override {
auto script = this->script(); auto script = this->script();
#if V8_ENABLE_WEBASSEMBLY #if V8_ENABLE_WEBASSEMBLY

1
src/inspector/v8-debugger-script.h
View File

@ -76,7 +76,6 @@ class V8DebuggerScript {
int executionContextId() const { return m_executionContextId; } int executionContextId() const { return m_executionContextId; }
virtual bool isLiveEdit() const = 0; virtual bool isLiveEdit() const = 0;
virtual bool isModule() const = 0; virtual bool isModule() const = 0;
virtual bool isSourceLoadedLazily() const = 0;
virtual int length() const = 0; virtual int length() const = 0;
void setSourceURL(const String16&); void setSourceURL(const String16&);