From 97450cb8d14d20617a8b57e22a650216d2c4b939 Mon Sep 17 00:00:00 2001 From: Reece Wilson Date: Fri, 9 Sep 2022 00:14:53 +0100 Subject: [PATCH] More incompetency from both the community and to a lesser extent Google (the latter obv doesnt give a shit about msvc support in any of their products) https://groups.google.com/g/v8-users/c/iMFNsV_cTEA > I am the current maintainer for Windows builds on VCPKG and Mingw-w64, the VCPKG version is probably exactly what you need, but it currently sits at 8.6. > I am working on an update to current stable version 8.8, but if it must be 8.7 you may have to see the port and figure it out yourself. - Feb 1, 2021 Meanwhile: https://github.com/microsoft/vcpkg/tree/master/ports/v8 > [v8] Update to version 9.1.269.39 - 14 months ago Even fucking older than our 9.6.0 candidate builds using shid intended for 2-3 year old v8. vcpkg bros, i dont feel so good --- include/cppgc/heap.h | 4 ++++ include/v8-cppgc.h | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/include/cppgc/heap.h b/include/cppgc/heap.h index 02ee12eaba..4a454300bc 100644 --- a/include/cppgc/heap.h +++ b/include/cppgc/heap.h @@ -112,6 +112,10 @@ class V8_EXPORT Heap { * heap through `Heap::Create()`. */ struct HeapOptions { + HeapOptions() = default; + HeapOptions(HeapOptions&&) = default; + HeapOptions(const HeapOptions&) = delete; + /** * Creates reasonable defaults for instantiating a Heap. * diff --git a/include/v8-cppgc.h b/include/v8-cppgc.h index f96709c783..0f18de2b12 100644 --- a/include/v8-cppgc.h +++ b/include/v8-cppgc.h @@ -77,6 +77,11 @@ struct WrapperDescriptor final { }; struct V8_EXPORT CppHeapCreateParams { + CppHeapCreateParams() = default; + CppHeapCreateParams(const CppHeapCreateParams&) = delete; + CppHeapCreateParams(CppHeapCreateParams&&) = default; + CppHeapCreateParams &operator = (const CppHeapCreateParams&) = delete; + std::vector> custom_spaces; WrapperDescriptor wrapper_descriptor; /**