AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

(Step 3 of 3): Prepping Wasm events in the Recorder interface

Browse Source 
Removed wall_clock_time_in_us field.

Bug: v8:11109
Change-Id: Ib3efa74fc741b793ef064c1d12ca1797be3a10c1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2550280
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Sara Tang <sartang@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#71386}
This commit is contained in:
Sara Tang 2020-11-20 18:18:21 -05:00 committed by Commit Bot
parent 52cfffde97
commit 9750bda3df
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/v8-metrics.h
View File

@ -10,14 +10,12 @@
namespace v8 { namespace v8 {
namespace metrics { namespace metrics {
// TODO(sartang@microsoft.com): Remove wall_clock_time_in_us.
struct WasmModuleDecoded { struct WasmModuleDecoded {
bool async = false; bool async = false;
bool streamed = false; bool streamed = false;
bool success = false; bool success = false;
size_t module_size_in_bytes = 0; size_t module_size_in_bytes = 0;
size_t function_count = 0; size_t function_count = 0;
int64_t wall_clock_time_in_us = -1;
int64_t wall_clock_duration_in_us = -1; int64_t wall_clock_duration_in_us = -1;
}; };
@ -30,7 +28,6 @@ struct WasmModuleCompiled {
bool success = false; bool success = false;
size_t code_size_in_bytes = 0; size_t code_size_in_bytes = 0;
size_t liftoff_bailout_count = 0; size_t liftoff_bailout_count = 0;
int64_t wall_clock_time_in_us = -1;
int64_t wall_clock_duration_in_us = -1; int64_t wall_clock_duration_in_us = -1;
}; };
@ -38,14 +35,12 @@ struct WasmModuleInstantiated {
bool async = false; bool async = false;
bool success = false; bool success = false;
size_t imported_function_count = 0; size_t imported_function_count = 0;
int64_t wall_clock_time_in_us = -1;
int64_t wall_clock_duration_in_us = -1; int64_t wall_clock_duration_in_us = -1;
}; };
struct WasmModuleTieredUp { struct WasmModuleTieredUp {
bool lazy = false; bool lazy = false;
size_t code_size_in_bytes = 0; size_t code_size_in_bytes = 0;
int64_t wall_clock_time_in_us = -1;
int64_t wall_clock_duration_in_us = -1; int64_t wall_clock_duration_in_us = -1;
}; };

6
src/wasm/module-compiler.cc
View File

@ -1463,7 +1463,6 @@ class CompilationTimeCallback {
true, // success true, // success
native_module->liftoff_code_size(), // code_size_in_bytes native_module->liftoff_code_size(), // code_size_in_bytes
native_module->liftoff_bailout_count(), // liftoff_bailout_count native_module->liftoff_bailout_count(), // liftoff_bailout_count
duration.InMicroseconds(), // wall_clock_time_in_us
duration.InMicroseconds() // wall_clock_duration_in_us duration.InMicroseconds() // wall_clock_duration_in_us
}; };
metrics_recorder_->DelayMainThreadEvent(event, context_id_); metrics_recorder_->DelayMainThreadEvent(event, context_id_);
@ -1475,7 +1474,6 @@ class CompilationTimeCallback {
v8::metrics::WasmModuleTieredUp event{ v8::metrics::WasmModuleTieredUp event{
FLAG_wasm_lazy_compilation, // lazy FLAG_wasm_lazy_compilation, // lazy
native_module->turbofan_code_size(), // code_size_in_bytes native_module->turbofan_code_size(), // code_size_in_bytes
duration.InMicroseconds(), // wall_clock_time_in_us
duration.InMicroseconds() // wall_clock_duration_in_us duration.InMicroseconds() // wall_clock_duration_in_us
}; };
metrics_recorder_->DelayMainThreadEvent(event, context_id_); metrics_recorder_->DelayMainThreadEvent(event, context_id_);
@ -1490,7 +1488,6 @@ class CompilationTimeCallback {
false, // success false, // success
native_module->liftoff_code_size(), // code_size_in_bytes native_module->liftoff_code_size(), // code_size_in_bytes
native_module->liftoff_bailout_count(), // liftoff_bailout_count native_module->liftoff_bailout_count(), // liftoff_bailout_count
duration.InMicroseconds(), // wall_clock_time_in_us
duration.InMicroseconds() // wall_clock_duration_in_us duration.InMicroseconds() // wall_clock_duration_in_us
}; };
metrics_recorder_->DelayMainThreadEvent(event, context_id_); metrics_recorder_->DelayMainThreadEvent(event, context_id_);
@ -1880,7 +1877,6 @@ void AsyncCompileJob::FinishCompile(bool is_after_cache_hit) {
!compilation_state->failed(), // success !compilation_state->failed(), // success
native_module_->liftoff_code_size(), // code_size_in_bytes native_module_->liftoff_code_size(), // code_size_in_bytes
native_module_->liftoff_bailout_count(), // liftoff_bailout_count native_module_->liftoff_bailout_count(), // liftoff_bailout_count
duration.InMicroseconds(), // wall_clock_time_in_us
duration.InMicroseconds() // wall_clock_duration_in_us duration.InMicroseconds() // wall_clock_duration_in_us
}; };
isolate_->metrics_recorder()->DelayMainThreadEvent(event, context_id_); isolate_->metrics_recorder()->DelayMainThreadEvent(event, context_id_);
@ -2395,7 +2391,6 @@ void AsyncStreamingProcessor::FinishAsyncCompileJobWithError(
job_->metrics_event_.streamed = true; job_->metrics_event_.streamed = true;
job_->metrics_event_.module_size_in_bytes = job_->wire_bytes_.length(); job_->metrics_event_.module_size_in_bytes = job_->wire_bytes_.length();
job_->metrics_event_.function_count = num_functions_; job_->metrics_event_.function_count = num_functions_;
job_->metrics_event_.wall_clock_time_in_us = duration.InMicroseconds();
job_->metrics_event_.wall_clock_duration_in_us = duration.InMicroseconds(); job_->metrics_event_.wall_clock_duration_in_us = duration.InMicroseconds();
job_->isolate_->metrics_recorder()->DelayMainThreadEvent(job_->metrics_event_, job_->isolate_->metrics_recorder()->DelayMainThreadEvent(job_->metrics_event_,
job_->context_id_); job_->context_id_);
@ -2619,7 +2614,6 @@ void AsyncStreamingProcessor::OnFinishedStream(OwnedVector<uint8_t> bytes) {
job_->metrics_event_.streamed = true; job_->metrics_event_.streamed = true;
job_->metrics_event_.module_size_in_bytes = job_->wire_bytes_.length(); job_->metrics_event_.module_size_in_bytes = job_->wire_bytes_.length();
job_->metrics_event_.function_count = num_functions_; job_->metrics_event_.function_count = num_functions_;
job_->metrics_event_.wall_clock_time_in_us = duration.InMicroseconds();
job_->metrics_event_.wall_clock_duration_in_us = duration.InMicroseconds(); job_->metrics_event_.wall_clock_duration_in_us = duration.InMicroseconds();
job_->isolate_->metrics_recorder()->DelayMainThreadEvent(job_->metrics_event_, job_->isolate_->metrics_recorder()->DelayMainThreadEvent(job_->metrics_event_,
job_->context_id_); job_->context_id_);