AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[ptr-compr][cleanup] Removing AccessBuilder::ForCompressedMap

Browse Source 
Now that we introduced the Compressed representation, we can simply use
AccessBuilder::ForMap. AccessBuilder::ForCompressedMap was introduced
as a placeholder previously.

Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng
Bug: v8:8977, v8:7703
Change-Id: I15b559c27641e6a673862c86be176e259835308e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617664
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61645}
This commit is contained in:
Santiago Aboy Solanes 2019-05-17 13:46:19 +01:00 committed by Commit Bot
parent 9f773b6e8d
commit 9850002401
3 changed files with 2 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/compiler/access-builder.cc
View File

@ -53,18 +53,6 @@ FieldAccess AccessBuilder::ForMap() {
return access;
}
// static
FieldAccess AccessBuilder::ForCompressedMap() {
FieldAccess access = {kTaggedBase, HeapObject::kMapOffset,
MaybeHandle<Name>(), MaybeHandle<Map>(),
// We use MachineType::Uint32() for the compressed
// pointer load, because we want to examine it
// as a compressed pointer in map checks.
Type::OtherInternal(), MachineType::Uint32(),
kMapWriteBarrier, LoadSensitivity::kUnsafe};
return access;
}
// static
FieldAccess AccessBuilder::ForHeapNumberValue() {
FieldAccess access = {

2
src/compiler/access-builder.h
View File

@ -36,8 +36,6 @@ class V8_EXPORT_PRIVATE AccessBuilder final
// Provides access to HeapObject::map() field.
static FieldAccess ForMap();
static FieldAccess ForCompressedMap();
// Provides access to HeapNumber::value() field.
static FieldAccess ForHeapNumberValue();

9
src/compiler/effect-control-linearizer.cc
View File

@ -1808,10 +1808,7 @@ void EffectControlLinearizer::LowerCheckMaps(Node* node, Node* frame_state) {
auto done = __ MakeLabel();
// Load the current map of the {value}.
Node* value_map =
UsingCompressedPointers()
? __ LoadField(AccessBuilder::ForCompressedMap(), value)
: __ LoadField(AccessBuilder::ForMap(), value);
Node* value_map = __ LoadField(AccessBuilder::ForMap(), value);
for (size_t i = 0; i < map_count; ++i) {
Node* check;
@ -1851,9 +1848,7 @@ Node* EffectControlLinearizer::LowerCompareMaps(Node* node) {
auto done = __ MakeLabel(MachineRepresentation::kBit);
// Load the current map of the {value}.
Node* value_map = UsingCompressedPointers()
? __ LoadField(AccessBuilder::ForCompressedMap(), value)
: __ LoadField(AccessBuilder::ForMap(), value);
Node* value_map = __ LoadField(AccessBuilder::ForMap(), value);
for (size_t i = 0; i < map_count; ++i) {
Node* check;