AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Skip some cctest when concurrent sparkplug

Browse Source 
The cpu profiler tests require a precise trace and become
flaky when running with concurrent sparkplug.

Bug: v8:12054
Change-Id: I62a20d15530c610bc1091371781c28687c718720
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289158
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77972}
This commit is contained in:
Victor Gomes 2021-11-17 14:19:26 +01:00 committed by V8 LUCI CQ
parent 5dad97b0a5
commit 9889f08e0e
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/cctest/test-cpu-profiler.cc
View File

@ -1373,6 +1373,10 @@ static const char* call_function_test_source =
// 1 1 bar [-1] #7 // 1 1 bar [-1] #7
// 19 19 (program) [-1] #2 // 19 19 (program) [-1] #2
TEST(FunctionCallSample) { TEST(FunctionCallSample) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(env->GetIsolate()); v8::HandleScope scope(env->GetIsolate());
@ -1430,6 +1434,10 @@ static const char* function_apply_test_source =
// 2 2 bar [-1] #16 6 // 2 2 bar [-1] #16 6
// 10 10 (program) [-1] #0 2 // 10 10 (program) [-1] #0 2
TEST(FunctionApplySample) { TEST(FunctionApplySample) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(env->GetIsolate()); v8::HandleScope scope(env->GetIsolate());
@ -1909,6 +1917,10 @@ static const char* inlining_test_source2 = R"(
// bailed out due to 'Optimization is always disabled' // bailed out due to 'Optimization is always disabled'
// 2 (program):0 0 #2 // 2 (program):0 0 #2
TEST(Inlining2) { TEST(Inlining2) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (FLAG_concurrent_sparkplug) return;
FLAG_allow_natives_syntax = true; FLAG_allow_natives_syntax = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
LocalContext env; LocalContext env;
@ -1997,6 +2009,10 @@ static const char* cross_script_source_b = R"(
)"; )";
TEST(CrossScriptInliningCallerLineNumbers) { TEST(CrossScriptInliningCallerLineNumbers) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
LocalContext env; LocalContext env;
@ -2088,6 +2104,10 @@ static const char* cross_script_source_f = R"(
)"; )";
TEST(CrossScriptInliningCallerLineNumbers2) { TEST(CrossScriptInliningCallerLineNumbers2) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(CcTest::isolate()); v8::HandleScope scope(CcTest::isolate());