cppgc: Fix build dependencies
- cppgc_headers: Do not depend on any internals but merely expose the public API interface. - v8_libbase: Do not depend on v8_headers but merely on v8_config_headers as src/base should be independent of general V8. Bug: chromium:1056170 Change-Id: I06d1a4ea20f243bae8e994deba9d76f07993ed4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720303 Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73060}
This commit is contained in:
parent
0eca1c7b25
commit
98998d1579
28
BUILD.gn
28
BUILD.gn
@ -4403,7 +4403,7 @@ v8_component("v8_libbase") {
|
|||||||
|
|
||||||
public_configs = [ ":libbase_config" ]
|
public_configs = [ ":libbase_config" ]
|
||||||
|
|
||||||
deps = [ ":v8_headers" ]
|
deps = [ ":v8_config_headers" ]
|
||||||
|
|
||||||
data = []
|
data = []
|
||||||
|
|
||||||
@ -4685,21 +4685,6 @@ v8_header_set("cppgc_headers") {
|
|||||||
":cppgc_header_features",
|
":cppgc_header_features",
|
||||||
]
|
]
|
||||||
|
|
||||||
sources = [
|
|
||||||
"include/cppgc/garbage-collected.h",
|
|
||||||
"include/cppgc/member.h",
|
|
||||||
"include/cppgc/persistent.h",
|
|
||||||
"include/cppgc/type-traits.h",
|
|
||||||
"include/cppgc/visitor.h",
|
|
||||||
]
|
|
||||||
|
|
||||||
deps = [ ":cppgc_base" ]
|
|
||||||
public_deps = [ ":v8_headers" ]
|
|
||||||
}
|
|
||||||
|
|
||||||
v8_source_set("cppgc_base") {
|
|
||||||
visibility = [ ":*" ]
|
|
||||||
|
|
||||||
sources = [
|
sources = [
|
||||||
"include/cppgc/allocation.h",
|
"include/cppgc/allocation.h",
|
||||||
"include/cppgc/common.h",
|
"include/cppgc/common.h",
|
||||||
@ -4735,6 +4720,15 @@ v8_source_set("cppgc_base") {
|
|||||||
"include/cppgc/trace-trait.h",
|
"include/cppgc/trace-trait.h",
|
||||||
"include/cppgc/type-traits.h",
|
"include/cppgc/type-traits.h",
|
||||||
"include/cppgc/visitor.h",
|
"include/cppgc/visitor.h",
|
||||||
|
]
|
||||||
|
|
||||||
|
public_deps = [ ":v8_config_headers" ]
|
||||||
|
}
|
||||||
|
|
||||||
|
v8_source_set("cppgc_base") {
|
||||||
|
visibility = [ ":*" ]
|
||||||
|
|
||||||
|
sources = [
|
||||||
"src/heap/cppgc/allocation.cc",
|
"src/heap/cppgc/allocation.cc",
|
||||||
"src/heap/cppgc/compaction-worklists.cc",
|
"src/heap/cppgc/compaction-worklists.cc",
|
||||||
"src/heap/cppgc/compaction-worklists.h",
|
"src/heap/cppgc/compaction-worklists.h",
|
||||||
@ -4838,7 +4832,7 @@ v8_source_set("cppgc_base") {
|
|||||||
]
|
]
|
||||||
|
|
||||||
public_deps = [
|
public_deps = [
|
||||||
":v8_config_headers",
|
":cppgc_headers",
|
||||||
":v8_cppgc_shared",
|
":v8_cppgc_shared",
|
||||||
":v8_libbase",
|
":v8_libbase",
|
||||||
":v8_libplatform",
|
":v8_libplatform",
|
||||||
|
Loading…
Reference in New Issue
Block a user