AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[rwx][mac] Fix broken component build

Browse Source 
Bug: v8:12797
Change-Id: I2e7f7812b47882766d5accb1963301e7c0731fcd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616725
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80285}
This commit is contained in:
Igor Sheludko 2022-04-29 19:43:47 +02:00 committed by V8 LUCI CQ
parent 5d53c2b482
commit 98f6f100c5
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/cctest/heap/test-concurrent-allocation.cc
View File

@ -452,8 +452,8 @@ class ConcurrentRecordRelocSlotThread final : public v8::base::Thread {
void Run() override {
LocalHeap local_heap(heap_, ThreadKind::kBackground);
UnparkedScope unparked_scope(&local_heap);
RwxMemoryWriteScope rwx_write_scope(
"Modification of Code object requires write access");
// Modification of Code object requires write access.
RwxMemoryWriteScopeForTesting rwx_write_scope;
int mode_mask = RelocInfo::EmbeddedObjectModeMask();
for (RelocIterator it(code_, mode_mask); !it.done(); it.next()) {
DCHECK(RelocInfo::IsEmbeddedObjectMode(it.rinfo()->rmode()));

5
test/cctest/heap/test-spaces.cc
View File

@ -193,9 +193,8 @@ TEST(MemoryChunk) {
base::PageInitializationMode::kAllocatedPagesCanBeUninitialized,
page_freeing_mode);
RwxMemoryWriteScope rwx_write_scope(
"Modification of pages in code_range_reservation requires write "
"access");
// Modification of pages in code_range_reservation requires write access.
RwxMemoryWriteScopeForTesting rwx_write_scope;
VerifyMemoryChunk(isolate, heap, &code_page_allocator, area_size,
EXECUTABLE, PageSize::kLarge, heap->code_lo_space());