Don't explicitly tear down code range in cctest/test-alloc/CodeRange to avoid double-free.

BUG=v8:4141
LOG=n
R=mlippautz@chromium.org

Review URL: https://codereview.chromium.org/1312213007 .

Cr-Commit-Position: refs/heads/master@{#30371}
This commit is contained in:
Hannes Payer 2015-08-26 11:28:18 +02:00
parent 0ee4b47368
commit 9a3327adad
3 changed files with 4 additions and 9 deletions

View File

@ -931,10 +931,6 @@ class CodeRange {
// Returns false on failure.
bool SetUp(size_t requested_size);
// Frees the range of virtual memory, and frees the data structures used to
// manage it.
void TearDown();
bool valid() { return code_range_ != NULL; }
Address start() {
DCHECK(valid());
@ -964,6 +960,10 @@ class CodeRange {
void ReleaseEmergencyBlock();
private:
// Frees the range of virtual memory, and frees the data structures used to
// manage it.
void TearDown();
Isolate* isolate_;
// The reserved range of virtual memory that all code objects are put in.

View File

@ -130,9 +130,6 @@
# TODO(machenbach, mvstanton): Flaky in debug on all platforms.
'test-lockers/LockerUnlocker': [PASS, ['mode == debug', FLAKY]],
# BUG(4141).
'test-alloc/CodeRange': [PASS, FLAKY],
}], # ALWAYS
##############################################################################

View File

@ -243,6 +243,4 @@ TEST(CodeRange) {
}
}
}
code_range.TearDown();
}