AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Skip GCTracerTest.* tests with --stress-incremental-marking

Browse Source 
Tests don't work when incremental marking is started before the test
is run.

Bug: v8:13267
Change-Id: I00e30ede96bfe3632ef701436395479f5ef083ec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026843
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84259}
This commit is contained in:
Dominik Inführ 2022-11-15 10:00:43 +01:00 committed by V8 LUCI CQ
parent f3917347b2
commit 9a5a020975
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/unittests/heap/gc-tracer-unittest.cc
View File

@ -119,6 +119,7 @@ void StopTracing(GCTracer* tracer, GarbageCollector collector) {
} // namespace
TEST_F(GCTracerTest, AllocationThroughput) {
if (v8_flags.stress_incremental_marking) return;
// GCTracer::AllocationThroughputInBytesPerMillisecond ignores global memory.
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -147,6 +148,7 @@ TEST_F(GCTracerTest, AllocationThroughput) {
}
TEST_F(GCTracerTest, PerGenerationAllocationThroughput) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -184,6 +186,7 @@ TEST_F(GCTracerTest, PerGenerationAllocationThroughput) {
}
TEST_F(GCTracerTest, PerGenerationAllocationThroughputWithProvidedTime) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -228,6 +231,7 @@ TEST_F(GCTracerTest, PerGenerationAllocationThroughputWithProvidedTime) {
}
TEST_F(GCTracerTest, RegularScope) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -242,6 +246,7 @@ TEST_F(GCTracerTest, RegularScope) {
}
TEST_F(GCTracerTest, IncrementalScope) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -258,6 +263,7 @@ TEST_F(GCTracerTest, IncrementalScope) {
}
TEST_F(GCTracerTest, IncrementalMarkingDetails) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -307,6 +313,7 @@ TEST_F(GCTracerTest, IncrementalMarkingDetails) {
}
TEST_F(GCTracerTest, IncrementalMarkingSpeed) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -357,6 +364,7 @@ TEST_F(GCTracerTest, IncrementalMarkingSpeed) {
}
TEST_F(GCTracerTest, MutatorUtilization) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
@ -393,6 +401,7 @@ TEST_F(GCTracerTest, MutatorUtilization) {
}
TEST_F(GCTracerTest, BackgroundScavengerScope) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
StartTracing(tracer, GarbageCollector::SCAVENGER, StartTracingMode::kAtomic);
@ -407,6 +416,7 @@ TEST_F(GCTracerTest, BackgroundScavengerScope) {
}
TEST_F(GCTracerTest, BackgroundMinorMCScope) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
StartTracing(tracer, GarbageCollector::MINOR_MARK_COMPACTOR,
@ -433,6 +443,7 @@ TEST_F(GCTracerTest, BackgroundMinorMCScope) {
}
TEST_F(GCTracerTest, BackgroundMajorMCScope) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
tracer->ResetForTesting();
tracer->AddScopeSample(GCTracer::Scope::MC_BACKGROUND_MARKING, 100);
@ -479,6 +490,7 @@ class ThreadWithBackgroundScope final : public base::Thread {
};
TEST_F(GCTracerTest, MultithreadedBackgroundScope) {
if (v8_flags.stress_incremental_marking) return;
GCTracer* tracer = i_isolate()->heap()->tracer();
ThreadWithBackgroundScope thread1(tracer);
ThreadWithBackgroundScope thread2(tracer);