AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Compiler] Remove script_data from BackgroundCompileTask.

Browse Source 
This field is dead since https://chromium-review.googlesource.com/c/v8/v8/+/916261, but got
accidentally added back by https://chromium-review.googlesource.com/c/v8/v8/+/919481 due to
a bad merge.

BUG=v8:5203,chromium:817258

Change-Id: Id6f06de84de7dcd4e6d467edf28974912ad33571
Reviewed-on: https://chromium-review.googlesource.com/948849
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51738}
This commit is contained in:
Ross McIlroy 2018-03-05 15:38:13 +00:00 committed by Commit Bot
parent 0bb70b8f75
commit 9a97d9756d
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/compiler.cc
View File

@ -898,7 +898,6 @@ class BackgroundCompileTask : public ScriptCompiler::ScriptStreamingTask {
private:
ScriptStreamingData* source_; // Not owned.
int stack_size_;
ScriptData* script_data_;
AccountingAllocator* allocator_;
TimedHistogram* timer_;
@ -909,7 +908,6 @@ BackgroundCompileTask::BackgroundCompileTask(ScriptStreamingData* source,
Isolate* isolate)
: source_(source),
stack_size_(i::FLAG_stack_size),
script_data_(nullptr),
timer_(isolate->counters()->compile_script_on_background()) {
VMState<PARSER> state(isolate);
@ -968,15 +966,6 @@ void BackgroundCompileTask::Run() {
source_->info.get(), allocator_, &source_->inner_function_jobs);
}
if (script_data_ != nullptr) {
source_->cached_data.reset(new ScriptCompiler::CachedData(
script_data_->data(), script_data_->length(),
ScriptCompiler::CachedData::BufferOwned));
script_data_->ReleaseDataOwnership();
delete script_data_;
script_data_ = nullptr;
}
source_->info->EmitBackgroundParseStatisticsOnBackgroundThread();
source_->info->set_on_background_thread(false);