AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

build: Make cppgc_base a public dependency

Browse Source 
Similar to V8, we provide the include/ headers through a "base" target.

Without this change, `gn check` complains about including cppgc headers
in Blink.

Bug: chromium:1056170
Change-Id: I09ad943cdfedae8c83ab7f957efba796637b8d48
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2617087
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71979}
This commit is contained in:
Michael Lippautz 2021-01-08 15:55:57 +01:00 committed by Commit Bot
parent 37c3e05e81
commit 9b057ef1f0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -3858,7 +3858,6 @@ v8_source_set("v8_base_without_compiler") {
]
deps = [
":cppgc_base",
":torque_generated_definitions",
":v8_cppgc_shared",
":v8_headers",
@ -3872,6 +3871,7 @@ v8_source_set("v8_base_without_compiler") {
]
public_deps = [
":cppgc_base",
":generate_bytecode_builtins_list",
":run_torque",
":v8_maybe_icu",