AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[web snapshot] Faster DescriptorArray setup

Browse Source 
Use DescriptorArray::Set instead of Append to avoid resorting the
descriptors for every newly added property

Bug: v8:11525
Change-Id: Id6d113f6218e095125256a8c7c8cfb28c8b41ae5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3415391
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78769}
This commit is contained in:
Camillo Bruni 2022-01-25 16:30:00 +01:00 committed by V8 LUCI CQ
parent f49f6bb571
commit 9b2b6140f3
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/web-snapshot/web-snapshot.cc
View File

@ -1295,8 +1295,9 @@ void WebSnapshotDeserializer::DeserializeMaps() {
} }
Handle<DescriptorArray> descriptors = Handle<DescriptorArray> descriptors =
isolate_->factory()->NewDescriptorArray(0, property_count); isolate_->factory()->NewDescriptorArray(property_count, 0);
for (uint32_t p = 0; p < property_count; ++p) { // for (uint32_t p = 0; p < property_count; ++p) {
for (InternalIndex i : InternalIndex::Range(property_count)) {
PropertyAttributes attributes = PropertyAttributes::NONE; PropertyAttributes attributes = PropertyAttributes::NONE;
if (has_custom_property_attributes) { if (has_custom_property_attributes) {
uint32_t flags; uint32_t flags;
@ -1311,11 +1312,12 @@ void WebSnapshotDeserializer::DeserializeMaps() {
// Use the "none" representation until we see the first object having this // Use the "none" representation until we see the first object having this
// map. At that point, modify the representation. // map. At that point, modify the representation.
Descriptor desc = Descriptor desc = Descriptor::DataField(
Descriptor::DataField(isolate_, key, static_cast<int>(p), attributes, isolate_, key, i.as_int(), attributes, Representation::None());
Representation::None()); descriptors->Set(i, &desc);
descriptors->Append(&desc);
} }
DCHECK_EQ(descriptors->number_of_descriptors(), property_count);
descriptors->Sort();
Handle<Map> map = isolate_->factory()->NewMap( Handle<Map> map = isolate_->factory()->NewMap(
JS_OBJECT_TYPE, JSObject::kHeaderSize * kTaggedSize, HOLEY_ELEMENTS, 0); JS_OBJECT_TYPE, JSObject::kHeaderSize * kTaggedSize, HOLEY_ELEMENTS, 0);