From 9ba4b74e1da8713be98ae56b7669fdcc9aefda66 Mon Sep 17 00:00:00 2001 From: "jochen@chromium.org" Date: Wed, 22 Jan 2014 13:59:05 +0000 Subject: [PATCH] Fix invalid memory access when initializing the command line in d8 BUG=none R=dcarney@chromium.org LOG=n Review URL: https://codereview.chromium.org/143983012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18753 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/d8.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/d8.cc b/src/d8.cc index 1560b09a2b..76ff4f9431 100644 --- a/src/d8.cc +++ b/src/d8.cc @@ -1564,13 +1564,14 @@ int Shell::RunMain(Isolate* isolate, int argc, char* argv[]) { #ifdef V8_SHARED static void SetStandaloneFlagsViaCommandLine() { - int fake_argc = 2; - char **fake_argv = new char*[2]; + int fake_argc = 3; + char **fake_argv = new char*[3]; fake_argv[0] = NULL; fake_argv[1] = strdup("--trace-hydrogen-file=hydrogen.cfg"); fake_argv[2] = strdup("--redirect-code-traces-to=code.asm"); v8::V8::SetFlagsFromCommandLine(&fake_argc, fake_argv, false); free(fake_argv[1]); + free(fake_argv[2]); delete[] fake_argv; } #endif