AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[interpreter] equivalence_id_ field type change

Browse Source 
There are a same name field equivalence_id_ in both
BytecodeRegisterOptimizer and RegisterInfo, but one of them is int,
another one is uint32_t, it's better to change them as same type
to avoid addtional or potential type casting.

Change-Id: I509f850d82a9a0fc30168fae83a0bd6565b7000e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3811138
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Wenqin Yang <wenqin.yang@intel.com>
Cr-Commit-Position: refs/heads/main@{#82214}
This commit is contained in:
wenqin.yang 2022-08-05 14:11:13 +08:00 committed by V8 LUCI CQ
parent 2055c3b482
commit 9cb95a0e6b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/interpreter/bytecode-register-optimizer.h
View File

@ -180,8 +180,7 @@ class V8_EXPORT_PRIVATE BytecodeRegisterOptimizer final
uint32_t NextEquivalenceId() { uint32_t NextEquivalenceId() {
equivalence_id_++; equivalence_id_++;
// TODO(rmcilroy): use the same type for these and remove static_cast. CHECK_NE(equivalence_id_, kInvalidEquivalenceId);
CHECK_NE(static_cast<size_t>(equivalence_id_), kInvalidEquivalenceId);
return equivalence_id_; return equivalence_id_;
} }
@ -201,7 +200,7 @@ class V8_EXPORT_PRIVATE BytecodeRegisterOptimizer final
ZoneDeque<RegisterInfo*> registers_needing_flushed_; ZoneDeque<RegisterInfo*> registers_needing_flushed_;
// Counter for equivalence sets identifiers. // Counter for equivalence sets identifiers.
int equivalence_id_; uint32_t equivalence_id_;
BytecodeWriter* bytecode_writer_; BytecodeWriter* bytecode_writer_;
bool flush_required_; bool flush_required_;