AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Try 2: Land --omit-default-ctors

Browse Source 
Bug: v8:13091
Change-Id: Ie7919904852043765c346630d0435458d437962e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3991026
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84003}
This commit is contained in:
Marja Hölttä 2022-10-28 14:40:59 +02:00 committed by V8 LUCI CQ
parent 6eb8316e7a
commit 9d0de43f39
3 changed files with 48 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flags/flag-definitions.h
View File

@ -637,7 +637,7 @@ DEFINE_BOOL(stress_lazy_source_positions, false,
"collect lazy source positions immediately after lazy compile")
DEFINE_STRING(print_bytecode_filter, "*",
"filter for selecting which functions to print bytecode")
DEFINE_BOOL(omit_default_ctors, false, "omit calling default ctors in bytecode")
DEFINE_BOOL(omit_default_ctors, true, "omit calling default ctors in bytecode")
#ifdef V8_TRACE_UNOPTIMIZED
DEFINE_BOOL(trace_unoptimized, false,
"trace the bytecodes executed by all unoptimized execution")

28
test/unittests/interpreter/bytecode_expectations/ClassAndSuperClass.golden
View File

@ -87,17 +87,21 @@ snippet: "
test = new B().constructor;
})();
"
frame size: 5
frame size: 8
parameter count: 1
bytecode array length: 39
bytecode array length: 52
bytecodes: [
B(Mov), R(closure), R(1),
/* 118 S> */ B(LdaSmi), I8(1),
B(Star4),
B(Ldar), R(1),
/* 118 E> */ B(GetSuperConstructor), R(3),
/* 118 E> */ B(FindNonDefaultConstructorOrConstruct), R(1), R(0), R(6),
B(Ldar), R(6),
B(Mov), R(1), R(2),
B(Mov), R(0), R(5),
B(Mov), R(7), R(3),
B(JumpIfTrue), U8(12),
B(ThrowIfNotSuperConstructor), R(3),
B(Ldar), R(0),
B(Ldar), R(5),
/* 118 E> */ B(Construct), R(3), R(4), U8(1), U8(0),
B(Star3),
B(Ldar), R(this),
@ -130,15 +134,19 @@ snippet: "
test = new B().constructor;
})();
"
frame size: 4
frame size: 7
parameter count: 1
bytecode array length: 36
bytecode array length: 49
bytecodes: [
B(Mov), R(closure), R(1),
/* 117 S> */ B(Ldar), R(1),
/* 117 E> */ B(GetSuperConstructor), R(3),
/* 117 S> */ B(FindNonDefaultConstructorOrConstruct), R(1), R(0), R(5),
B(Ldar), R(5),
B(Mov), R(1), R(2),
B(Mov), R(0), R(4),
B(Mov), R(6), R(3),
B(JumpIfTrue), U8(12),
B(ThrowIfNotSuperConstructor), R(3),
B(Ldar), R(0),
B(Ldar), R(4),
/* 117 E> */ B(Construct), R(3), R(0), U8(0), U8(0),
B(Star3),
B(Ldar), R(this),

45
test/unittests/interpreter/bytecode_expectations/SuperCallAndSpread.golden
View File

@ -17,18 +17,25 @@ snippet: "
test = new B(1, 2, 3).constructor;
})();
"
frame size: 5
frame size: 9
parameter count: 1
bytecode array length: 19
bytecode array length: 38
bytecodes: [
/* 93 E> */ B(CreateRestParameter),
B(Star2),
B(Mov), R(closure), R(1),
/* 93 S> */ B(Ldar), R(1),
/* 93 E> */ B(GetSuperConstructor), R(4),
/* 93 S> */ B(FindNonDefaultConstructorOrConstruct), R(1), R(0), R(7),
B(Mov), R(2), R(5),
B(Ldar), R(7),
B(Mov), R(1), R(3),
B(Mov), R(0), R(6),
B(Mov), R(8), R(4),
B(JumpIfTrue), U8(12),
B(ThrowIfNotSuperConstructor), R(4),
B(Ldar), R(0),
/* 93 E> */ B(ConstructWithSpread), R(4), R(2), U8(1), U8(0),
B(Ldar), R(6),
/* 93 E> */ B(ConstructWithSpread), R(4), R(5), U8(1), U8(0),
B(Star4),
B(Ldar), R(4),
/* 93 S> */ B(Return),
]
constant pool: [
@ -49,9 +56,9 @@ snippet: "
test = new B(1, 2, 3).constructor;
})();
"
frame size: 8
frame size: 11
parameter count: 1
bytecode array length: 38
bytecode array length: 51
bytecodes: [
/* 128 E> */ B(CreateRestParameter),
B(Star3),
@ -59,11 +66,15 @@ bytecodes: [
B(Mov), R(3), R(2),
/* 140 S> */ B(LdaSmi), I8(1),
B(Star6),
B(Ldar), R(closure),
/* 140 E> */ B(GetSuperConstructor), R(5),
B(ThrowIfNotSuperConstructor), R(5),
B(Ldar), R(0),
/* 140 E> */ B(FindNonDefaultConstructorOrConstruct), R(closure), R(0), R(9),
B(Mov), R(3), R(7),
B(Ldar), R(9),
B(Mov), R(1), R(4),
B(Mov), R(0), R(8),
B(Mov), R(10), R(5),
B(JumpIfTrue), U8(12),
B(ThrowIfNotSuperConstructor), R(5),
B(Ldar), R(8),
/* 140 E> */ B(ConstructWithSpread), R(5), R(6), U8(2), U8(0),
B(Star5),
B(Ldar), R(this),
@ -93,7 +104,7 @@ snippet: "
"
frame size: 11
parameter count: 1
bytecode array length: 94
bytecode array length: 101
bytecodes: [
/* 128 E> */ B(CreateRestParameter),
B(Star3),
@ -122,10 +133,12 @@ bytecodes: [
B(JumpLoop), U8(31), I8(0), U8(18),
B(LdaSmi), I8(1),
B(StaInArrayLiteral), R(6), R(7), U8(12),
B(Ldar), R(4),
/* 140 E> */ B(GetSuperConstructor), R(5),
B(ThrowIfNotSuperConstructor), R(5),
/* 140 E> */ B(FindNonDefaultConstructorOrConstruct), R(4), R(0), R(8),
B(Ldar), R(8),
B(Mov), R(0), R(7),
B(Mov), R(9), R(5),
B(JumpIfTrue), U8(9),
B(ThrowIfNotSuperConstructor), R(5),
B(CallJSRuntime), U8(%reflect_construct), R(5), U8(3),
B(Star5),
B(Ldar), R(this),