From 9d4772db3e84317adae09de957a9f0e3b439def2 Mon Sep 17 00:00:00 2001 From: Tobias Tebbi Date: Tue, 25 Jun 2019 12:51:59 +0200 Subject: [PATCH] [torque] add notice to Torque exception usage Change-Id: Ie5dbbf7cd17571c6ad1b0e83613bce605d0b9257 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675956 Reviewed-by: Michael Stanton Commit-Queue: Tobias Tebbi Cr-Commit-Position: refs/heads/master@{#62355} --- BUILD.gn | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 6a5dff6d22..0f4141e0d0 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -3375,6 +3375,9 @@ v8_source_set("torque_base") { ":v8_libbase", ] + # The use of exceptions for Torque in violation of the Chromium style-guide + # is justified by the fact that it is only used from the non-essential + # language server and can be removed anytime if it causes problems. configs = [ ":internal_config", "//build/config/compiler:exceptions", @@ -3417,6 +3420,9 @@ v8_source_set("torque_ls_base") { ":torque_base", ] + # The use of exceptions for Torque in violation of the Chromium style-guide + # is justified by the fact that it is only used from the non-essential + # language server and can be removed anytime if it causes problems. configs = [ ":internal_config", "//build/config/compiler:exceptions", @@ -3845,6 +3851,9 @@ if (current_toolchain == v8_snapshot_toolchain) { "//build/win:default_exe_manifest", ] + # The use of exceptions for Torque in violation of the Chromium style-guide + # is justified by the fact that it is only used from the non-essential + # language server and can be removed anytime if it causes problems. configs = [ ":internal_config", "//build/config/compiler:exceptions", @@ -3875,6 +3884,9 @@ v8_executable("torque-language-server") { "//build/win:default_exe_manifest", ] + # The use of exceptions for Torque in violation of the Chromium style-guide + # is justified by the fact that it is only used from the non-essential + # language server and can be removed anytime if it causes problems. configs = [ ":internal_config", "//build/config/compiler:exceptions",