AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[snapshot] Fix clearing compiled code from JSFunction pt. 2

Browse Source 
Optimized code that is marked for deoptimization is not considered
'attached' or 'available', but we still want to discard it prior to
serialization. Change JSFunction::CanDiscardCompiled to explicitly
check for this case.

Bug: v8:10881, v8:10869
Change-Id: Id573c21e331afdae28be4ab434d522249d1ac9be
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2409275
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69868}
This commit is contained in:
Jakob Gruber 2020-09-14 09:06:16 +02:00 committed by Commit Bot
parent c9224589cf
commit 9dc89efa50
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/objects/js-function.cc
View File

@ -157,8 +157,12 @@ bool JSFunction::CanDiscardCompiled() const {
// from JS code? We can currently tell only indirectly, by looking at // from JS code? We can currently tell only indirectly, by looking at
// available code kinds. If any JS code kind exists, we can discard. // available code kinds. If any JS code kind exists, we can discard.
// //
// Attached optimized code that is marked for deoptimization will not show up
// in the list of available code kinds, thus we must check for it manually.
//
// Note that when the function has not yet been compiled we also return // Note that when the function has not yet been compiled we also return
// false; that's fine, since nothing must be discarded in that case. // false; that's fine, since nothing must be discarded in that case.
if (code().kind() == CodeKind::OPTIMIZED_FUNCTION) return true;
CodeKinds result = GetAvailableCodeKinds(); CodeKinds result = GetAvailableCodeKinds();
return (result & kJSFunctionCodeKindsMask) != 0; return (result & kJSFunctionCodeKindsMask) != 0;
} }