AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Disable FastApiCPUProfiler in nci_as_midtier

Browse Source 
This CL moves the disabling to the test source code.

Bug: v8:11178
Change-Id: I9771c1eb2ea474143bb401ba40f4452f6e6572ec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2549963
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71278}
This commit is contained in:
Maya Lekova 2020-11-19 14:05:55 +01:00 committed by Commit Bot
parent 8818bb9a5b
commit 9e111d3f28
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/cctest/cctest.status
View File

@ -668,9 +668,6 @@
# NCI code currently does not use the feedback vector's optimized code cache.
'test-compiler/OptimizedCodeSharing1': [SKIP],
# TODO(v8:11178): Re-enable once the cause of the failure is fixed.
'test-cpu-profiler/FastApiCPUProfiler': [SKIP],
}], # variant == nci or variant == nci_as_midtier
]

2
test/cctest/test-cpu-profiler.cc
View File

@ -3934,8 +3934,10 @@ v8::Local<v8::Function> CreateApiCode(LocalContext* env) {
TEST(FastApiCPUProfiler) {
#if !defined(V8_LITE_MODE) && !defined(USE_SIMULATOR)
// None of the following configurations include JSCallReducer.
if (i::FLAG_jitless) return;
if (i::FLAG_turboprop) return;
if (i::FLAG_turbo_nci_as_midtier) return;
FLAG_SCOPE_EXTERNAL(opt);
FLAG_SCOPE_EXTERNAL(turbo_fast_api_calls);