AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cctest] Reducing recursion depth for asan tests.

Browse Source 
Drive-by-fix: improve threading test log output by also showing the names of the
tests when they start and end.

Review-Url: https://codereview.chromium.org/2218033002
Cr-Commit-Position: refs/heads/master@{#38402}
This commit is contained in:
cbruni 2016-08-05 13:56:06 -07:00 committed by Commit bot
parent 56c8814c0b
commit 9e4a304008
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/cctest/test-api.cc
View File

@ -2478,8 +2478,7 @@ THREADED_TEST(UndefinedIsNotEnumerable) {
v8::Local<Script> call_recursively_script;
static const int kTargetRecursionDepth = 150; // near maximum
static const int kTargetRecursionDepth = 100; // near maximum
static void CallScriptRecursivelyCall(
const v8::FunctionCallbackInfo<v8::Value>& args) {
@ -13807,6 +13806,16 @@ void ApiTestFuzzer::TearDown() {
}
}
void ApiTestFuzzer::CallTest() {
v8::Isolate::Scope scope(CcTest::isolate());
if (kLogThreading)
printf("Start test %s #%d\n",
RegisterThreadedTest::nth(test_number_)->name(), test_number_);
CallTestNumber(test_number_);
if (kLogThreading)
printf("End test %s #%d\n", RegisterThreadedTest::nth(test_number_)->name(),
test_number_);
}
// Lets not be needlessly self-referential.
TEST(Threading1) {
@ -13837,16 +13846,6 @@ TEST(Threading4) {
}
void ApiTestFuzzer::CallTest() {
v8::Isolate::Scope scope(CcTest::isolate());
if (kLogThreading)
printf("Start test %d\n", test_number_);
CallTestNumber(test_number_);
if (kLogThreading)
printf("End test %d\n", test_number_);
}
static void ThrowInJS(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::Isolate* isolate = args.GetIsolate();
CHECK(v8::Locker::IsLocked(isolate));