From 9e7732c5175e31409e57ff38474b76afab07c6c4 Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Wed, 17 Jun 2015 07:55:54 -0700 Subject: [PATCH] Reenable some cctest tests that no longer fail. R=jochen@chromium.org,jarin@chromium.org TEST=cctest Review URL: https://codereview.chromium.org/1176423007 Cr-Commit-Position: refs/heads/master@{#29092} --- src/heap/mark-compact.h | 2 -- test/cctest/cctest.status | 13 ++++--------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h index a252bea7c6..de21aa1d90 100644 --- a/src/heap/mark-compact.h +++ b/src/heap/mark-compact.h @@ -209,7 +209,6 @@ class MarkingDeque { // heap. INLINE(void PushBlack(HeapObject* object)) { DCHECK(object->IsHeapObject()); - DCHECK(object->map()->IsMap()); if (IsFull()) { Marking::BlackToGrey(object); MemoryChunk::IncrementLiveBytesFromGC(object->address(), -object->Size()); @@ -222,7 +221,6 @@ class MarkingDeque { INLINE(void PushGrey(HeapObject* object)) { DCHECK(object->IsHeapObject()); - DCHECK(object->map()->IsMap()); if (IsFull()) { SetOverflowed(); } else { diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 844e4f52b6..bfe660ee50 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -64,11 +64,13 @@ # are actually 13 * 38 * 5 * 128 = 316160 individual tests hidden here. 'test-parsing/ParserSync': [PASS, NO_VARIANTS], - # This tests only the type system, so there is no point in running several - # variants. + # This tests only the type system, no point in running several variants. 'test-hydrogen-types/*': [PASS, NO_VARIANTS], 'test-types/*': [PASS, NO_VARIANTS], + # This tests API threading, no point in running several variants. + 'test-api/Threading*': [PASS, NO_VARIANTS], + # The cpu profiler tests are notoriously flaky. # BUG(2999). (test/cpu-profiler/CollectCpuProfile) # BUG(3287). (test-cpu-profiler/SampleWhenFrameIsNotSetup) @@ -98,7 +100,6 @@ # TurboFan compiler failures. # Some tests are just too slow to run for now. - 'test-api/Threading*': [PASS, NO_VARIANTS], 'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [PASS, NO_VARIANTS], 'test-heap-profiler/ManyLocalsInSharedContext': [PASS, NO_VARIANTS], 'test-serialize/SerializeToplevelLargeCodeObject': [PASS, NO_VARIANTS], @@ -116,12 +117,6 @@ 'test-debug/ScriptBreakPointByIdThroughJavaScript': [PASS, NO_VARIANTS], 'test-debug/ScriptBreakPointByNameThroughJavaScript': [PASS, NO_VARIANTS], - # TODO(jarin): Cannot lazy-deoptimize from conversions before comparisons. - 'test-js-typed-lowering/OrderCompareEffects': [SKIP], - - # TODO(jochen): Reenable after we removed the CHECK() from the marking queue. - 'test-mark-compact/MarkingDeque': [SKIP], - ############################################################################ # Slow tests. 'test-api/Threading1': [PASS, ['mode == debug', SLOW]],