AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix re-indexing for literals in do-expressions

Browse Source 
This became temporarily a big issue, because spreads are desugared
into do-expressions.  This patch fixes the problem with having
spreads as parameter initializers in arrow expressions, e.g., this
line would crash:

    [], ((x = [...[42]]) => x)();

R=rossberg@chromium.org
BUG=chromium:578038
LOG=N

Review URL: https://codereview.chromium.org/1581403007

Cr-Commit-Position: refs/heads/master@{#33365}
This commit is contained in:
nikolaos 2016-01-18 07:20:42 -08:00 committed by Commit bot
parent e4b41d64e5
commit 9ed5596ade
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ast/ast-expression-visitor.cc
View File

@ -208,6 +208,7 @@ void AstExpressionVisitor::VisitNativeFunctionLiteral(
void AstExpressionVisitor::VisitDoExpression(DoExpression* expr) {
VisitExpression(expr);
RECURSE(VisitBlock(expr->block()));
RECURSE(VisitVariableProxy(expr->result()));
}

3
src/ast/ast-literal-reindexer.cc
View File

@ -44,7 +44,8 @@ void AstLiteralReindexer::VisitNativeFunctionLiteral(
void AstLiteralReindexer::VisitDoExpression(DoExpression* node) {
// TODO(caitp): literals in do expressions need re-indexing too.
Visit(node->block());
Visit(node->result());
}

16
test/mjsunit/harmony/regress/regress-crbug-578038.js Normal file
View File

@ -0,0 +1,16 @@
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-do-expressions
(function testWithoutOtherLiteral() {
var result = ((x = [...[42]]) => x)();
assertEquals(result, [42]);
})();
(function testWithSomeOtherLiteral() {
[]; // important: an array literal before the arrow function
var result = ((x = [...[42]]) => x)(); // will core dump, if not fixed.
assertEquals(result, [42]);
})();