AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Remove Heap::external_memory_concurrently_freed

Browse Source 
The only user was ArrayBufferTracker which got removed already.

Bug: v8:10064
Change-Id: I97f8ed0727abec01b3b65ba965026f61fb9acb85
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346406
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69354}
This commit is contained in:
Dominik Inführ 2020-08-10 15:01:03 +02:00 committed by Commit Bot
parent 4fa691ed75
commit 9f26032cfb
3 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/heap/heap-inl.h
View File

@ -91,16 +91,6 @@ void Heap::update_external_memory(int64_t delta) {
}
}
void Heap::update_external_memory_concurrently_freed(uintptr_t freed) {
external_memory_concurrently_freed_ += freed;
}
void Heap::account_external_memory_concurrently_freed() {
update_external_memory(
-static_cast<int64_t>(external_memory_concurrently_freed_));
external_memory_concurrently_freed_ = 0;
}
RootsTable& Heap::roots_table() { return isolate()->roots_table(); }
#define ROOT_ACCESSOR(Type, name, CamelName) \

2
src/heap/heap.h
View File

@ -668,8 +668,6 @@ class Heap {
V8_INLINE int64_t external_memory();
V8_INLINE void update_external_memory(int64_t delta);
V8_INLINE void update_external_memory_concurrently_freed(uintptr_t freed);
V8_INLINE void account_external_memory_concurrently_freed();
V8_EXPORT_PRIVATE size_t YoungArrayBufferBytes();
V8_EXPORT_PRIVATE size_t OldArrayBufferBytes();

4
src/heap/mark-compact.cc
View File

@ -894,8 +894,6 @@ void MarkCompactCollector::Prepare() {
heap_->safepoint()->IterateLocalHeaps(
[](LocalHeap* local_heap) { local_heap->FreeLinearAllocationArea(); });
}
heap()->account_external_memory_concurrently_freed();
}
void MarkCompactCollector::FinishConcurrentMarking(
@ -4495,8 +4493,6 @@ void MinorMarkCompactCollector::CollectGarbage() {
heap()->new_lo_space()->FreeDeadObjects([](HeapObject) { return true; });
}
heap()->account_external_memory_concurrently_freed();
SweepArrayBufferExtensions();
}