AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] remove unneeded call to LowerInlineAllocationLimit

Browse Source 
Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to be
a no-op.

  new_space_.LowerInlineAllocationLimit(
      new_space_.inline_allocation_limit_step());

LowerInlineAllocatoinLimit does the following things:

1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
   already been called when new_space_.ResetAllocationInfo was called above.
3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
   ResetAllocationInfo as well.

BUG=
R=hpayer@chromium.org,ulan@chromium.org

Review URL: https://codereview.chromium.org/1390013002

Cr-Commit-Position: refs/heads/master@{#31156}
This commit is contained in:
ofrobots 2015-10-07 08:19:37 -07:00 committed by Commit bot
parent 77faf5d0f1
commit 9f8e8b835a
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/heap/heap.cc
View File

@ -1689,9 +1689,6 @@ void Heap::Scavenge() {
// Set age mark.
new_space_.set_age_mark(new_space_.top());
new_space_.LowerInlineAllocationLimit(
new_space_.inline_allocation_limit_step());
array_buffer_tracker()->FreeDead(true);
// Update how much has survived scavenge.

4
src/heap/spaces.h
View File

@ -2702,10 +2702,6 @@ class NewSpace : public Space {
bool IsFromSpaceCommitted() { return from_space_.is_committed(); }
inline intptr_t inline_allocation_limit_step() {
return inline_allocation_limit_step_;
}
SemiSpace* active_space() { return &to_space_; }
private: