From 9fbc83286a563ce5d42f0505c70151e9fc1ee274 Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Wed, 20 Jan 2021 17:00:44 +0000 Subject: [PATCH] Revert "[build] Enable external flag header by default" This reverts commit d1da9694d45880dd94bfbd47857afac8a6c1ffd2. Reason for revert: Compile error on msvc: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc/16456/overview Original change's description: > [build] Enable external flag header by default > > Turns on v8_generate_external_defines_header. > > Bug: v8:11292 > Change-Id: I4b1d9b47390b560b7cbf677948310694d8b03367 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2610966 > Reviewed-by: Ross McIlroy > Commit-Queue: Dan Elphick > Auto-Submit: Dan Elphick > Cr-Commit-Position: refs/heads/master@{#72201} TBR=rmcilroy@chromium.org,delphick@chromium.org Change-Id: Ia0005704b9e3b33acc73c088d287e66a99360423 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640418 Reviewed-by: Clemens Backes Commit-Queue: Clemens Backes Cr-Commit-Position: refs/heads/master@{#72202} --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index b37c2f85ab..31638ad5e6 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -288,7 +288,7 @@ declare_args() { # If enabled then macro definitions that are used in externally visible # header files are placed in a separate header file v8-gn.h. - v8_generate_external_defines_header = true + v8_generate_external_defines_header = false } # Derived defaults.