Reland "[tools] Add benchmark owners to the config"
This is a reland of 989285b7a0
Original change's description:
> [tools] Add benchmark owners to the config
>
> R=machenbach@chromium.org
>
> No-Try: true
> Bug: chromium:826280
> Change-Id: Ic34d13170dfecdd9e791974a34c33ba0248c7a38
> Reviewed-on: https://chromium-review.googlesource.com/1053809
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53138}
TBR=machenbach@chromium.org
No-Try: true
Bug: chromium:826280
Change-Id: I169788ff40dd88a7017b46a15b292568b907f38e
Reviewed-on: https://chromium-review.googlesource.com/1061697
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53215}
This commit is contained in:
parent
b595b89c36
commit
9fc3551a7b
@ -1,4 +1,5 @@
|
||||
{
|
||||
"owners": ["jarin@chromium.org", "mvstanston@chromium.org"],
|
||||
"name": "JSTests",
|
||||
"run_count": 3,
|
||||
"run_count_arm": 1,
|
||||
|
@ -1,4 +1,5 @@
|
||||
{
|
||||
"owners": ["jgruber@chromium.org", "yangguo@chromium.org"],
|
||||
"name": "RegExp",
|
||||
"run_count": 3,
|
||||
"run_count_arm": 1,
|
||||
|
@ -1,4 +1,5 @@
|
||||
{
|
||||
"owners": ["jarin@chromium.org", "mvstanston@chromium.org"],
|
||||
"name": "SixSpeed",
|
||||
"run_count": 3,
|
||||
"run_count_arm": 1,
|
||||
|
@ -1,4 +1,5 @@
|
||||
{
|
||||
"owners": ["yangguo@chromium.org"],
|
||||
"name": "Memory",
|
||||
"run_count": 5,
|
||||
"units": "bytes",
|
||||
|
@ -11,6 +11,7 @@ Call e.g. with tools/run-perf.py --arch ia32 some_suite.json
|
||||
The suite json format is expected to be:
|
||||
{
|
||||
"path": <relative path chunks to perf resources and main file>,
|
||||
"owners": [<list of email addresses of benchmark owners (required)>],
|
||||
"name": <optional suite name, file name is default>,
|
||||
"archs": [<architecture name for which this suite is run>, ...],
|
||||
"binary": <name of binary to run, default "d8">,
|
||||
@ -55,6 +56,7 @@ A suite without "tests" is considered a performance test itself.
|
||||
Full example (suite with one runner):
|
||||
{
|
||||
"path": ["."],
|
||||
"owner": ["username@chromium.org"],
|
||||
"flags": ["--expose-gc"],
|
||||
"test_flags": ["5"],
|
||||
"archs": ["ia32", "x64"],
|
||||
@ -74,6 +76,7 @@ Full example (suite with one runner):
|
||||
Full example (suite with several runners):
|
||||
{
|
||||
"path": ["."],
|
||||
"owner": ["username@chromium.org", "otherowner@google.com"],
|
||||
"flags": ["--expose-gc"],
|
||||
"archs": ["ia32", "x64"],
|
||||
"run_count": 5,
|
||||
@ -402,6 +405,7 @@ class GraphConfig(Node):
|
||||
self._suite = suite
|
||||
|
||||
assert isinstance(suite.get("path", []), list)
|
||||
assert isinstance(suite.get("owners", []), list)
|
||||
assert isinstance(suite["name"], basestring)
|
||||
assert isinstance(suite.get("flags", []), list)
|
||||
assert isinstance(suite.get("test_flags", []), list)
|
||||
@ -412,6 +416,7 @@ class GraphConfig(Node):
|
||||
self.graphs = parent.graphs[:] + [suite["name"]]
|
||||
self.flags = parent.flags[:] + suite.get("flags", [])
|
||||
self.test_flags = parent.test_flags[:] + suite.get("test_flags", [])
|
||||
self.owners = parent.owners[:] + suite.get("owners", [])
|
||||
|
||||
# Values independent of parent node.
|
||||
self.resources = suite.get("resources", [])
|
||||
@ -452,6 +457,7 @@ class TraceConfig(GraphConfig):
|
||||
def __init__(self, suite, parent, arch):
|
||||
super(TraceConfig, self).__init__(suite, parent, arch)
|
||||
assert self.results_regexp
|
||||
assert self.owners
|
||||
|
||||
def CreateMeasurement(self, perform_measurement):
|
||||
if not perform_measurement:
|
||||
|
Loading…
Reference in New Issue
Block a user