AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove unused --inline-accessors flag

Browse Source 
This flag has had no effect since mid 2017 when its use-site was
accidentally removed (in https://codereview.chromium.org/2902533003).

Change-Id: I81436b064c2664deff781ad6d75ad47937e3fdc0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934333
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65172}
This commit is contained in:
Georg Neis 2019-11-25 16:28:15 +01:00 committed by Commit Bot
parent d39ecaf144
commit a0206daa78
7 changed files with 24 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/codegen/optimized-compilation-info.h
View File

@ -44,28 +44,27 @@ class V8_EXPORT_PRIVATE OptimizedCompilationInfo final {
// Various configuration flags for a compilation, as well as some properties
// of the compiled code produced by a compilation.
enum Flag {
kAccessorInliningEnabled = 1 << 0,
kFunctionContextSpecializing = 1 << 1,
kInliningEnabled = 1 << 2,
kDisableFutureOptimization = 1 << 3,
kSplittingEnabled = 1 << 4,
kSourcePositionsEnabled = 1 << 5,
kBailoutOnUninitialized = 1 << 6,
kLoopPeelingEnabled = 1 << 7,
kUntrustedCodeMitigations = 1 << 8,
kSwitchJumpTableEnabled = 1 << 9,
kCalledWithCodeStartRegister = 1 << 10,
kPoisonRegisterArguments = 1 << 11,
kAllocationFoldingEnabled = 1 << 12,
kAnalyzeEnvironmentLiveness = 1 << 13,
kTraceTurboJson = 1 << 14,
kTraceTurboGraph = 1 << 15,
kTraceTurboScheduled = 1 << 16,
kTraceTurboAllocation = 1 << 17,
kTraceHeapBroker = 1 << 18,
kWasmRuntimeExceptionSupport = 1 << 19,
kTurboControlFlowAwareAllocation = 1 << 20,
kTurboPreprocessRanges = 1 << 21
kFunctionContextSpecializing = 1 << 0,
kInliningEnabled = 1 << 1,
kDisableFutureOptimization = 1 << 2,
kSplittingEnabled = 1 << 3,
kSourcePositionsEnabled = 1 << 4,
kBailoutOnUninitialized = 1 << 5,
kLoopPeelingEnabled = 1 << 6,
kUntrustedCodeMitigations = 1 << 7,
kSwitchJumpTableEnabled = 1 << 8,
kCalledWithCodeStartRegister = 1 << 9,
kPoisonRegisterArguments = 1 << 10,
kAllocationFoldingEnabled = 1 << 11,
kAnalyzeEnvironmentLiveness = 1 << 12,
kTraceTurboJson = 1 << 13,
kTraceTurboGraph = 1 << 14,
kTraceTurboScheduled = 1 << 15,
kTraceTurboAllocation = 1 << 16,
kTraceHeapBroker = 1 << 17,
kWasmRuntimeExceptionSupport = 1 << 18,
kTurboControlFlowAwareAllocation = 1 << 19,
kTurboPreprocessRanges = 1 << 20
};
// Construct a compilation info for optimized compilation.
@ -113,11 +112,6 @@ class V8_EXPORT_PRIVATE OptimizedCompilationInfo final {
return GetFlag(kFunctionContextSpecializing);
}
void MarkAsAccessorInliningEnabled() { SetFlag(kAccessorInliningEnabled); }
bool is_accessor_inlining_enabled() const {
return GetFlag(kAccessorInliningEnabled);
}
void MarkAsSourcePositionsEnabled() { SetFlag(kSourcePositionsEnabled); }
bool is_source_positions_enabled() const {
return GetFlag(kSourcePositionsEnabled);

6
src/compiler/js-native-context-specialization.h
View File

@ -44,11 +44,7 @@ class V8_EXPORT_PRIVATE JSNativeContextSpecialization final
: public AdvancedReducer {
public:
// Flags that control the mode of operation.
enum Flag {
kNoFlags = 0u,
kAccessorInliningEnabled = 1u << 0,
kBailoutOnUninitialized = 1u << 1
};
enum Flag { kNoFlags = 0u, kBailoutOnUninitialized = 1u << 0 };
using Flags = base::Flags<Flag>;
JSNativeContextSpecialization(Editor* editor, JSGraph* jsgraph,

6
src/compiler/pipeline.cc
View File

@ -1003,9 +1003,6 @@ PipelineCompilationJob::Status PipelineCompilationJob::PrepareJobImpl(
if (FLAG_turbo_inlining) {
compilation_info()->MarkAsInliningEnabled();
}
if (FLAG_inline_accessors) {
compilation_info()->MarkAsAccessorInliningEnabled();
}
// This is the bottleneck for computing and setting poisoning level in the
// optimizing compiler.
@ -1301,9 +1298,6 @@ struct InliningPhase {
: MaybeHandle<JSFunction>());
JSNativeContextSpecialization::Flags flags =
JSNativeContextSpecialization::kNoFlags;
if (data->info()->is_accessor_inlining_enabled()) {
flags |= JSNativeContextSpecialization::kAccessorInliningEnabled;
}
if (data->info()->is_bailout_on_uninitialized()) {
flags |= JSNativeContextSpecialization::kBailoutOnUninitialized;
}

2
src/flags/flag-definitions.h
View File

@ -484,7 +484,6 @@ DEFINE_BOOL(trace_generalization, false, "trace map generalization")
DEFINE_BOOL(turboprop, false,
"enable experimental turboprop mid-tier compiler.")
DEFINE_NEG_IMPLICATION(turboprop, turbo_inlining)
DEFINE_NEG_IMPLICATION(turboprop, inline_accessors)
DEFINE_VALUE_IMPLICATION(turboprop, interrupt_budget, 10 * KB)
// Flags for concurrent recompilation.
@ -597,7 +596,6 @@ DEFINE_VALUE_IMPLICATION(stress_inline, max_inlined_bytecode_size_absolute,
DEFINE_VALUE_IMPLICATION(stress_inline, min_inlining_frequency, 0)
DEFINE_IMPLICATION(stress_inline, polymorphic_inlining)
DEFINE_BOOL(trace_turbo_inlining, false, "trace TurboFan inlining")
DEFINE_BOOL(inline_accessors, true, "inline JavaScript accessors")
DEFINE_BOOL(turbo_inline_array_builtins, true,
"inline array builtins in TurboFan code")
DEFINE_BOOL(use_osr, true, "use on-stack replacement")

1
test/cctest/compiler/serializer-tester.cc
View File

@ -39,7 +39,6 @@ SerializerTester::SerializerTester(const char* source)
*v8::Local<v8::Function>::Cast(CompileRun(function_string.c_str()))));
uint32_t flags = i::OptimizedCompilationInfo::kInliningEnabled |
i::OptimizedCompilationInfo::kFunctionContextSpecializing |
i::OptimizedCompilationInfo::kAccessorInliningEnabled |
i::OptimizedCompilationInfo::kLoopPeelingEnabled |
i::OptimizedCompilationInfo::kBailoutOnUninitialized |
i::OptimizedCompilationInfo::kAllocationFoldingEnabled |

2
test/mjsunit/compiler/inline-accessors2.js
View File

@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --allow-natives-syntax --inline-accessors
// Flags: --allow-natives-syntax
var accessorCallCount, setterArgument, setterValue, obj, forceDeopt;

2
test/mjsunit/regress/regress-crbug-134609.js
View File

@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --allow-natives-syntax --inline-accessors
// Flags: --allow-natives-syntax
var forceDeopt = {x: 0};