AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[torque] Add lint rules for redundant clauses

Browse Source 
This change adds two simple lint rules to prevent including 'generates'
or 'constexpr' clauses in cases where they have no impact on behavior.

Bug: v8:7793
Change-Id: Ib1d8fde39ca26735ff9cb7892f01e464619c2090
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2590515
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#71831}
This commit is contained in:
Seth Brenith 2020-12-14 14:56:03 -08:00 committed by Commit Bot
parent eafc0eee95
commit a14107f73d
4 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/constructor.tq
View File

@ -17,7 +17,7 @@ namespace constructor {
extern builtin FastNewObject(Context, JSFunction, JSReceiver): JSObject; extern builtin FastNewObject(Context, JSFunction, JSReceiver): JSObject;
extern enum AllocationSiteMode constexpr 'AllocationSiteMode' { extern enum AllocationSiteMode {
DONT_TRACK_ALLOCATION_SITE, DONT_TRACK_ALLOCATION_SITE,
TRACK_ALLOCATION_SITE TRACK_ALLOCATION_SITE
} }

3
src/objects/js-array.tq
View File

@ -2,8 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
extern enum IterationKind extends uint31 extern enum IterationKind extends uint31 { kKeys, kValues, kEntries }
constexpr 'IterationKind' { kKeys, kValues, kEntries }
extern class JSArrayIterator extends JSObject { extern class JSArrayIterator extends JSObject {
iterated_object: JSReceiver; iterated_object: JSReceiver;

3
src/torque/torque-parser.cc
View File

@ -1281,6 +1281,9 @@ base::Optional<ParseResult> MakeEnumDeclaration(
NamingConventionError("Type", name, "UpperCamelCase"); NamingConventionError("Type", name, "UpperCamelCase");
} }
if (constexpr_generates_opt && *constexpr_generates_opt == name) {
Lint("Unnecessary 'constexpr' clause for enum ", name);
}
auto constexpr_generates = auto constexpr_generates =
constexpr_generates_opt ? *constexpr_generates_opt : name; constexpr_generates_opt ? *constexpr_generates_opt : name;
const bool generate_nonconstexpr = base_type_expression.has_value(); const bool generate_nonconstexpr = base_type_expression.has_value();

7
src/torque/type-visitor.cc
View File

@ -300,7 +300,12 @@ const ClassType* TypeVisitor::ComputeType(
if (flags & ClassFlag::kExtern) { if (flags & ClassFlag::kExtern) {
if (decl->generates) { if (decl->generates) {
bool enforce_tnode_type = true; bool enforce_tnode_type = true;
generates = ComputeGeneratesType(decl->generates, enforce_tnode_type); std::string explicit_generates =
ComputeGeneratesType(decl->generates, enforce_tnode_type);
if (explicit_generates == generates) {
Lint("Unnecessary 'generates' clause for class ", decl->name->value);
}
generates = explicit_generates;
} }
if (flags & ClassFlag::kExport) { if (flags & ClassFlag::kExport) {
Error("cannot export a class that is marked extern"); Error("cannot export a class that is marked extern");