AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

cppgc: Reenable pointer compression on all platforms but M1 and Fuchsia

Browse Source 
M1 is known to have regression in MotionMark.
Fuchsia fails due to binary size increase.

Bug: chromium:1325007
Change-Id: I599c53bf1318dfcc7b40764e89df81b972374ed3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835682
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82517}
This commit is contained in:
Anton Bikineev 2022-08-17 10:05:14 +02:00 committed by V8 LUCI CQ
parent 07b0574a39
commit a199f0997d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BUILD.gn
View File

@ -843,9 +843,11 @@ if (cppgc_enable_caged_heap) {
# Always enable young generation compile time flag if caged heap is enabled.
cppgc_enable_young_generation = true
if (is_linux || (is_mac && v8_current_cpu != "arm64") || is_win) {
# Always enable on desktop but avoid on ChromeOS for now (for stability
# reasons).
if (is_linux || (is_mac && v8_current_cpu != "arm64") || is_win ||
is_chromeos || is_android) {
# Enable on all platforms but M1 and Fuchsia.
# TODO(1325007): Fix MotionMark regressions on M1.
# TODO(1325007): Address binary size increase on Fuchsia.
cppgc_enable_pointer_compression = true
}
}