AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove obsolete {OptimizedCompilationInfo::wasm_code}.

Browse Source 
R=clemensh@chromium.org

Change-Id: I2ec2fdb2406efeaf3b48d0c58711db7e5172aa58
Reviewed-on: https://chromium-review.googlesource.com/c/1335699
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57525}
This commit is contained in:
Michael Starzinger 2018-11-15 09:54:13 +01:00 committed by Commit Bot
parent 0b13f0f517
commit a245611a3b
3 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/pipeline.cc
View File

@ -2403,8 +2403,6 @@ wasm::WasmCode* Pipeline::GenerateCodeForWasmFunction(
json_of << "\n}";
}
info->SetCode(code);
if (data.info()->trace_turbo_json_enabled() ||
data.info()->trace_turbo_graph_enabled()) {
CodeTracer::Scope tracing_scope(data.GetCodeTracer());

4
src/compiler/wasm-compiler.cc
View File

@ -5315,11 +5315,11 @@ void TurbofanWasmCompilationUnit::ExecuteCompilation(
call_descriptor = GetI32WasmCallDescriptor(&zone, call_descriptor);
}
if (Pipeline::GenerateCodeForWasmFunction(
if (wasm::WasmCode* wasm_code = Pipeline::GenerateCodeForWasmFunction(
&info, wasm_unit_->wasm_engine_, mcgraph, call_descriptor,
source_positions, node_origins, func_body, wasm_unit_->native_module_,
wasm_unit_->func_index_)) {
wasm_unit_->SetResult(info.wasm_code(), counters);
wasm_unit_->SetResult(wasm_code, counters);
}
if (FLAG_trace_wasm_decode_time) {
double pipeline_ms = pipeline_timer.Elapsed().InMillisecondsF();

14
src/optimized-compilation-info.h
View File

@ -8,7 +8,6 @@
#include <memory>
#include "src/bailout-reason.h"
#include "src/code-reference.h"
#include "src/frames.h"
#include "src/globals.h"
#include "src/handles.h"
@ -70,11 +69,7 @@ class V8_EXPORT_PRIVATE OptimizedCompilationInfo final {
Handle<SharedFunctionInfo> shared_info() const { return shared_info_; }
bool has_shared_info() const { return !shared_info().is_null(); }
Handle<JSFunction> closure() const { return closure_; }
Handle<Code> code() const { return code_.as_js_code(); }
wasm::WasmCode* wasm_code() const {
return const_cast<wasm::WasmCode*>(code_.as_wasm_code());
}
Handle<Code> code() const { return code_; }
Code::Kind code_kind() const { return code_kind_; }
uint32_t stub_key() const { return stub_key_; }
void set_stub_key(uint32_t stub_key) { stub_key_ = stub_key; }
@ -177,10 +172,7 @@ class V8_EXPORT_PRIVATE OptimizedCompilationInfo final {
// Code getters and setters.
template <typename T>
void SetCode(T code) {
code_ = CodeReference(code);
}
void SetCode(Handle<Code> code) { code_ = code; }
bool has_context() const;
Context* context() const;
@ -291,7 +283,7 @@ class V8_EXPORT_PRIVATE OptimizedCompilationInfo final {
Handle<JSFunction> closure_;
// The compiled code.
CodeReference code_;
Handle<Code> code_;
// Entry point when compiling for OSR, {BailoutId::None} otherwise.
BailoutId osr_offset_ = BailoutId::None();